Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: add warning on dynamic import es modules #30720

Closed
wants to merge 3 commits into from
Closed

lib: add warning on dynamic import es modules #30720

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bfc3e7f
lib: add warning on dynamic import es modules
juanarbol Nov 29, 2019
21813e3
fixup
juanarbol Dec 1, 2019
79e5c6b
fixup
juanarbol Dec 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/internal/process/esm_loader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ exports.initializeImportMetaObject = function(wrap, meta) {

exports.importModuleDynamicallyCallback = async function(wrap, specifier) {
assert(calledInitialize === true || !userLoader);
process.emitWarning(
'The ESM module loader is experimental.',
'ExperimentalWarning', undefined);
juanarbol marked this conversation as resolved.
Show resolved Hide resolved
const { callbackMap } = internalBinding('module_wrap');
if (callbackMap.has(wrap)) {
const { importModuleDynamically } = callbackMap.get(wrap);
Expand Down
8 changes: 8 additions & 0 deletions test/es-module/test-esm-dynamic-import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,14 @@ function expectFsNamespace(result) {
// For direct use of import expressions inside of CJS or ES modules, including
// via eval, all kinds of specifiers should work without issue.
(function testScriptOrModuleImport() {
// Warning should be emitted 9 times, bellow we're importing 9 ES modules.
const IMPORTED_DYNAMICALLY = 9;
process.on('warning', common.mustCall(({ name, code, message }) => {
assert.strictEqual(code, undefined);
assert.strictEqual(message, 'The ESM module loader is experimental.');
assert.strictEqual(name, 'ExperimentalWarning');
}, IMPORTED_DYNAMICALLY));

// Importing another file, both direct & via eval
// expectOkNamespace(import(relativePath));
expectOkNamespace(eval(`import("${relativePath}")`));
Expand Down