-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stream: improve write performance #30736
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
Issues and PRs related to the stream subsystem.
label
Nov 30, 2019
This comment has been minimized.
This comment has been minimized.
ronag
force-pushed
the
stream-afterwrite3
branch
2 times, most recently
from
November 30, 2019 15:23
c1311ea
to
601faeb
Compare
ronag
force-pushed
the
stream-afterwrite3
branch
3 times, most recently
from
November 30, 2019 16:19
feab352
to
520388b
Compare
ronag
commented
Nov 30, 2019
ronag
force-pushed
the
stream-afterwrite3
branch
4 times, most recently
from
November 30, 2019 20:29
092225e
to
5a99949
Compare
3 tasks
@ronag Could you review this? I’ll review this as soon as I can :) |
ronag
force-pushed
the
stream-afterwrite3
branch
from
December 1, 2019 06:38
5a99949
to
251ce92
Compare
@addaleax rebased |
A bit more modest improvement after #30710 confidence improvement accuracy (*) (**) (***)
streams/writable-manywrites.js sync='no' n=2000000 0.10 % ±1.46% ±1.94% ±2.54%
streams/writable-manywrites.js sync='yes' n=2000000 *** 8.43 % ±1.73% ±2.30% ±3.00% |
ronag
force-pushed
the
stream-afterwrite3
branch
2 times, most recently
from
December 1, 2019 09:38
6d04fa4
to
63da91b
Compare
lpinca
added
the
semver-major
PRs that contain breaking changes and should be released in the next major version.
label
Dec 1, 2019
Added semver-major label due to e828f510. |
Let's park this until #30733 is landed |
This needs a blocked label |
ronag
force-pushed
the
stream-afterwrite3
branch
from
December 14, 2019 21:21
63da91b
to
ee68b0d
Compare
This was referenced Sep 18, 2021
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
semver-major
PRs that contain breaking changes and should be released in the next major version.
stream
Issues and PRs related to the stream subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is inspired by #30710.
Depends on #30733 (which is included).
Improves performance of
write
by avoidingprocess.nextTick
and a number of conditions when possible in the hot path in sync mode.EDIT: A bit more modest improvement after #30710
Note since #30733 is probably semver major, this should be the same.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes