doc: remove imprecise and redundant testing text #30763
Merged
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
jasnell
approved these changes
Dec 2, 2019
cjihrig
approved these changes
Dec 2, 2019
Trott
added
the
author ready
lpinca
approved these changes
Dec 2, 2019
richardlau
approved these changes
Dec 2, 2019
Remove "All commits...are tested on these platforms." for the following reasons: * It's somewhat redundant. The surrounding text makes it clear that we test on these platforms. * It's imprecise. Commits, such as those that only affect documentation or linting do not get tested on all the platforms. (Well, perhaps they do in an after-the-fact kind of way when a subsequent commit gets tested, but I think that's a stretch.) PR-URL: nodejs#30763 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
Landed in ca11291 |
targos
pushed a commit
that referenced
this pull request
Dec 9, 2019
Remove "All commits...are tested on these platforms." for the following reasons: * It's somewhat redundant. The surrounding text makes it clear that we test on these platforms. * It's imprecise. Commits, such as those that only affect documentation or linting do not get tested on all the platforms. (Well, perhaps they do in an after-the-fact kind of way when a subsequent commit gets tested, but I think that's a stretch.) PR-URL: #30763 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 13, 2020
Remove "All commits...are tested on these platforms." for the following reasons: * It's somewhat redundant. The surrounding text makes it clear that we test on these platforms. * It's imprecise. Commits, such as those that only affect documentation or linting do not get tested on all the platforms. (Well, perhaps they do in an after-the-fact kind of way when a subsequent commit gets tested, but I think that's a stretch.) PR-URL: #30763 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Remove "All commits...are tested on these platforms." for the following reasons: * It's somewhat redundant. The surrounding text makes it clear that we test on these platforms. * It's imprecise. Commits, such as those that only affect documentation or linting do not get tested on all the platforms. (Well, perhaps they do in an after-the-fact kind of way when a subsequent commit gets tested, but I think that's a stretch.) PR-URL: #30763 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove "All commits...are tested on these platforms." for the following
reasons:
test on these platforms.
or linting do not get tested on all the platforms. (Well, perhaps they
do in an after-the-fact kind of way when a subsequent commit gets
tested, but I think that's a stretch.)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes