assert: handle (deep) equal(NaN, NaN) as being identical #30766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns the `equal` and `deepEqual()` implementations with the strict versions by accepting `NaN` as being identical in case both sides are NaN. Refs: nodejs#30350 (comment)
nodejs-github-bot
added
assert
BridgeAR
added
the
semver-major
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jasnell
approved these changes
Dec 2, 2019
lundibundi
approved these changes
Dec 3, 2019
addaleax
approved these changes
Dec 3, 2019
devnexen
approved these changes
Dec 3, 2019
BridgeAR
added
the
author ready
|
This probably requires an update to assert.md since this diverges from the Abstract Equality Comparison cited in the doc? |
I mean, I see the YAML is updated, but I think the actual text for |
|
@Trott I updated the documentation accordingly. |
Trott
reviewed
Dec 6, 2019
Trott
reviewed
Dec 6, 2019
Trott
reviewed
Dec 6, 2019
Trott
approved these changes
Dec 6, 2019
This comment has been minimized.
This comment has been minimized.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/27419/ ✅ (yellow build with two Windows flakes) |
BridgeAR
added a commit
that referenced
this pull request
Dec 6, 2019
This aligns the `equal` and `deepEqual()` implementations with the strict versions by accepting `NaN` as being identical in case both sides are NaN. Refs: #30350 (comment) PR-URL: #30766 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in 5360dd1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns the
equalanddeepEqual()implementation with thestrict version by accepting
NaNas being identical incase both sides are NaN.
Refs: #30350 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes