Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use callback arguments in getconnections test #30775

Merged
merged 0 commits into from
Dec 5, 2019
Merged

test: use callback arguments in getconnections test #30775

merged 0 commits into from
Dec 5, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 3, 2019

Use previously-unused callback arguments in
test-child-process-fork-getconnections.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 3, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27320/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27322/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27326/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 4, 2019
@Trott
Copy link
Member Author

Trott commented Dec 5, 2019

Landed in 7113d99

@Trott Trott closed this Dec 5, 2019
@Trott Trott merged commit 7113d99 into nodejs:master Dec 5, 2019
@Trott Trott deleted the getconn-mustcall branch December 5, 2019 16:04
targos pushed a commit that referenced this pull request Dec 9, 2019
@Trott @targos
test: use callback arguments in getconnections test
5067463 
Use previously-unused callback arguments in
test-child-process-fork-getconnections.

PR-URL: #30775
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
@Trott @targos
test: use callback arguments in getconnections test
f6356fe 
Use previously-unused callback arguments in
test-child-process-fork-getconnections.

PR-URL: #30775
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Trott @BethGriggs
test: use callback arguments in getconnections test
4bb8d6a 
Use previously-unused callback arguments in
test-child-process-fork-getconnections.

PR-URL: #30775
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @lpinca @gengjiawen