-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: change calls to deprecated util.print() #3083
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM |
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Sep 28, 2015
common.debug() is just util.debug() and emits a deprecation notice. Per docs, use console.error() instead. PR-URL: nodejs#3083 Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Trott
added a commit
that referenced
this pull request
Sep 28, 2015
common.print() is just util.print() and as such prints a deprecation warning. Per docs, update to console.log(). PR-URL: #3083 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Landed in 306936e |
Trott
added a commit
that referenced
this pull request
Sep 30, 2015
common.print() is just util.print() and as such prints a deprecation warning. Per docs, update to console.log(). PR-URL: #3083 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
This was referenced Sep 30, 2015
Trott
added a commit
that referenced
this pull request
Sep 30, 2015
common.print() is just util.print() and as such prints a deprecation warning. Per docs, update to console.log(). PR-URL: #3083 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
This was referenced Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common.print()
is justutil.print()
and as such prints a deprecation warning. Per docs, update toconsole.log()
.