Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: change calls to deprecated util.print() #3083

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 26, 2015

common.print() is just util.print() and as such prints a deprecation warning. Per docs, update to console.log().

@Trott Trott added the test Issues and PRs related to the tests. label Sep 26, 2015
@brendanashworth
Copy link
Contributor

LGTM

@Trott
Copy link
Member Author

Trott commented Sep 27, 2015

@targos
Copy link
Member

targos commented Sep 28, 2015

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Sep 28, 2015
common.debug() is just util.debug() and emits a deprecation notice. Per
docs, use console.error() instead.

PR-URL: nodejs#3083
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Trott added a commit that referenced this pull request Sep 28, 2015
common.print() is just util.print() and as such prints a deprecation
warning. Per docs, update to console.log().

PR-URL: #3083
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
@Trott
Copy link
Member Author

Trott commented Sep 28, 2015

Landed in 306936e

@Trott Trott closed this Sep 28, 2015
Trott added a commit that referenced this pull request Sep 30, 2015
common.print() is just util.print() and as such prints a deprecation
warning. Per docs, update to console.log().

PR-URL: #3083
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
This was referenced Sep 30, 2015
Trott added a commit that referenced this pull request Sep 30, 2015
common.print() is just util.print() and as such prints a deprecation
warning. Per docs, update to console.log().

PR-URL: #3083
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
@Trott Trott deleted the rm-common-print branch January 13, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants