Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark addons/openssl-bindings/test flaky on arm #30838

Closed
wants to merge 1 commit into from
Closed

test: mark addons/openssl-bindings/test flaky on arm #30838

wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

Refs: #30786

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Dec 7, 2019
@richardlau richardlau added arm Issues and PRs related to the ARM platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Dec 7, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 7, 2019 •
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/27457/

(From the above run here is the test failing and being marked flaky: https://ci.nodejs.org/job/node-test-binary-arm-12+/3034/RUN_SUBSET=addons,label=pi2-docker/)

@richardlau richardlau mentioned this pull request Dec 7, 2019
Open
@richardlau richardlau added the openssl Issues and PRs related to the OpenSSL dependency. label Dec 7, 2019
@cjihrig
Copy link
Contributor

cjihrig commented Dec 7, 2019

Should we fast track this? I think so. 👍 here if you agree.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27462/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27463/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 7, 2019 •
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/27464/ (⚠️)

@richardlau richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 7, 2019
richardlau added a commit that referenced this pull request Dec 7, 2019
@richardlau
test: mark addons/openssl-bindings/test flaky on arm
d4e00ec 
PR-URL: #30838
Refs: #30786
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@richardlau
Copy link
Member Author

Landed in d4e00ec.

@richardlau richardlau closed this Dec 7, 2019
@richardlau richardlau deleted the flaky branch December 7, 2019 21:09
targos pushed a commit that referenced this pull request Dec 9, 2019
@richardlau @targos
test: mark addons/openssl-bindings/test flaky on arm
4dc9d8d 
PR-URL: #30838
Refs: #30786
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@richardlau @targos
test: mark addons/openssl-bindings/test flaky on arm
39d770c 
PR-URL: #30838
Refs: #30786
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@richardlau @BethGriggs
test: mark addons/openssl-bindings/test flaky on arm
fe3818e 
PR-URL: #30838
Refs: #30786
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. arm Issues and PRs related to the ARM platform. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. openssl Issues and PRs related to the OpenSSL dependency. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@richardlau @nodejs-github-bot @cjihrig @addaleax @ZYSzys