test: mark tests as flaky #30848
Closed
test: mark tests as flaky #30848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
async_hooks
richardlau
approved these changes
Dec 8, 2019
|
Please approve this comment for fast-tracking. This is easy to change back if there's any objection, and would be good to have in master as soon as possible to help reading CI results for other PRs. |
joaocgreis
added
the
fast-track
gireeshpunathil
approved these changes
Dec 8, 2019
addaleax
approved these changes
Dec 8, 2019
Trott
approved these changes
Dec 8, 2019
Trott
pushed a commit
that referenced
this pull request
Dec 8, 2019
PR-URL: #30848 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
|
Landed in a2cfb7d |
targos
pushed a commit
that referenced
this pull request
Dec 9, 2019
PR-URL: #30848 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #30848 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #30848 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 24, 2020
PR-URL: #30848 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark a few tests that failed recently in master as flaky. Most of the tests are only marked flaky on Windows, except
test-statwatcherthat has failures documented for other platforms in its issue.cc @nodejs/testing @nodejs/platform-windows
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes