Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: accept single argument in getProxyDetails #30858

Closed
wants to merge 3 commits into from
Closed

src: accept single argument in getProxyDetails #30858

wants to merge 3 commits into from
+8 −3

Commits on Dec 8, 2019

  1. src: accept single argument in getProxyDetails 

    This makes sure this function stays backwards compatible in case
it's accessed through the binding directly.

Refs: nodejs#29947 (comment)
    @BridgeAR
    BridgeAR committed Dec 8, 2019
    Configuration menu
    Copy the full SHA
    578f0b0 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2019

  1. fixup: change comment to TODO

    @BridgeAR
    BridgeAR committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    e42bfc6 View commit details
    Browse the repository at this point in the history

  2. fixup: mention esm explictly

    @BridgeAR
    BridgeAR committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    aa2f0bf View commit details
    Browse the repository at this point in the history