Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: replace Symbol.iterator by SymbolIterator #30859

Closed
wants to merge 1 commit into from
Closed

lib: replace Symbol.iterator by SymbolIterator #30859

wants to merge 1 commit into from

Conversation

Sebastien-Ahkrin
Copy link
Contributor

Just replaced every Symbol.iterator by SymbolIterator in the lib/* folder

For this, i just have added SymbolIterator in the import

const {
  // [...]
  SymbolIterator,
} = primordials;

I hope this pull request will help you ! 😄

@Sebastien-Ahkrin
Copy link
Contributor Author

Refs: #30697

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27516/

@targos
Copy link
Member

targos commented Dec 11, 2019

Landed in c101251

@targos targos closed this Dec 11, 2019
targos pushed a commit that referenced this pull request Dec 11, 2019
@Sebastien-Ahkrin @targos
lib: replace Symbol.iterator by SymbolIterator
c101251 
PR-URL: #30859
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 13, 2019
@Sebastien-Ahkrin @MylesBorins
lib: replace Symbol.iterator by SymbolIterator
64ab5c9 
PR-URL: #30859
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@Sebastien-Ahkrin @targos
lib: replace Symbol.iterator by SymbolIterator
22df5dc 
PR-URL: #30859
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Sebastien-Ahkrin @BethGriggs
lib: replace Symbol.iterator by SymbolIterator
fb18ad4 
PR-URL: #30859
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sebastien-Ahkrin @nodejs-github-bot @targos @cjihrig @devnexen