Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 6.13.3 #30873

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 6.13.3 #30873

wants to merge 1 commit into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Dec 10, 2019

6.13.3 (2019-12-09)

DEPENDENCIES

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Dec 10, 2019
cjihrig
cjihrig approved these changes Dec 10, 2019
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

BridgeAR
BridgeAR approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@richardlau richardlau mentioned this pull request Dec 10, 2019
Closed
Trott
Trott approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27549/

@Trott
Copy link
Member

Trott commented Dec 10, 2019

CITGM: https://ci.nodejs.org/view/All/job/citgm-smoker/2121/

@Trott Trott added notable-change PRs with changes that should be highlighted in changelogs. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 10, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27574/

@Trott
Copy link
Member

Trott commented Dec 11, 2019 •
edited
Loading

CITGM results are fine. (The big failures there will be fixed by #30858 and are unrelated to this change.)

@richardlau
Copy link
Member

@isaacs Should we land this one first or skip straight to npm 6.13.4 (#30904)?

@Trott
Copy link
Member

Trott commented Dec 12, 2019

Closing in favor of #30904

@Trott Trott closed this Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. notable-change PRs with changes that should be highlighted in changelogs. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@isaacs @nodejs-github-bot @Trott @richardlau @cjihrig @gengjiawen @BridgeAR