build,win: support building MSI with VS2019 #30895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly pass the WiX SDK directory when building the MSI. WiX doesn't (yet?) have a directory for VS2019, so use the one for VS2017 which should be compatible.
joaocgreis
added
windows
nodejs-github-bot
added
install
This comment has been minimized.
This comment has been minimized.
richardlau
approved these changes
Dec 11, 2019
richardlau
reviewed
Dec 11, 2019
| @@ -58,6 +60,9 @@ _UpgradeReport_Files/ | |||
| *.wixobj | |||
| /tools/msvs/genfiles/ | |||
| /npm.wxs | |||
| /tools/msvs/msi/Release/ | |||
| /tools/msvs/msi/obj/ | |||
| /tools/msvs/msi/x64/ | |||
There was a problem hiding this comment.
Is there an equivalent /tools/msvs/msi/x86/?
There was a problem hiding this comment.
It's the Release/ folder. By default, VS uses Release/ for x86 and x64/Release/ for x64.
targos
approved these changes
Dec 11, 2019
BridgeAR
added
the
author ready
Trott
approved these changes
Dec 13, 2019
|
Landed in 654d22c |
Trott
pushed a commit
that referenced
this pull request
Dec 13, 2019
Explicitly pass the WiX SDK directory when building the MSI. WiX doesn't (yet?) have a directory for VS2019, so use the one for VS2017 which should be compatible. PR-URL: #30895 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 17, 2019
Explicitly pass the WiX SDK directory when building the MSI. WiX doesn't (yet?) have a directory for VS2019, so use the one for VS2017 which should be compatible. PR-URL: #30895 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly pass the WiX SDK directory when building the MSI. WiX doesn't (yet?) have a directory for VS2019, so use the one for VS2017 which should be compatible.
cc @nodejs/platform-windows
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes