wasi: update WASI version to snapshot1 #30980

cjihrig · 2019-12-15T16:40:37Z

This PR updates the uvwasi dependency and Node's WASI code to support the latest version of the WASI API, snapshot 1. It also removes a now obsolete test.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Trott

Needs a rebase.

This commit updates to uvwasi 0.0.3, which implements a newer version of the WASI spec, snapshot_1. Since the WASI API has changed, this also requires updating the WebAssembly memory interfacing logic and recompiling the WASI tests with a version of wasi-libc that supports snapshot_1.

The WASI API has moved from preview0 to preview1. This commit updates the CLI flag accordingly.

test-wasi-binding.js was added during the initial WASI development, but it is now considered obsolete. It also does not provide any additional test coverage. This commit removes it.

nodejs-github-bot · 2019-12-17T18:30:20Z

CI: https://ci.nodejs.org/job/node-test-pull-request/27771/ 💛

Trott · 2019-12-18T01:35:50Z

Landed in 145116b...ec4bf4a

This commit updates to uvwasi 0.0.3, which implements a newer version of the WASI spec, snapshot_1. Since the WASI API has changed, this also requires updating the WebAssembly memory interfacing logic and recompiling the WASI tests with a version of wasi-libc that supports snapshot_1. PR-URL: #30980 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

The WASI API has moved from preview0 to preview1. This commit updates the CLI flag accordingly. PR-URL: #30980 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

test-wasi-binding.js was added during the initial WASI development, but it is now considered obsolete. It also does not provide any additional test coverage. This commit removes it. PR-URL: #30980 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>

During the migration to WASI snapshot1, a field was removed from the subscription type. The field was removed from the code, but the bounds checking logic was not updated. This commit updates that check. Similarly, __wasi_linkcount_t changed from a uint32_t to a uint64_t. However, the bounds checks were missed, and the code was still writing uint32_t's (to the new correct offset) instead of uint64_t's. This commit updates that logic as well. Refs: nodejs#30980

During the migration to WASI snapshot1, a field was removed from the subscription type. The field was removed from the code, but the bounds checking logic was not updated. This commit updates that check. Similarly, __wasi_linkcount_t changed from a uint32_t to a uint64_t. However, the bounds checks were missed, and the code was still writing uint32_t's (to the new correct offset) instead of uint64_t's. This commit updates that logic as well. Refs: #30980 PR-URL: #31122 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>