Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: reference worker threads on signal events #30990

Closed
wants to merge 2 commits into from
Closed

doc: reference worker threads on signal events #30990

wants to merge 2 commits into from

Conversation

legendecas
Copy link
Member

Though there is a note on Worker Threads that signals are not available. It is still convenient to be mentioned on docs of signal events.

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Dec 16, 2019
@legendecas
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4111/

Trott
Trott reviewed Dec 17, 2019
View reviewed changes
doc/api/process.md Outdated Show resolved Hide resolved
@legendecas @Trott
Update doc/api/process.md
9c08c46 
Co-Authored-By: Rich Trott <rtrott@gmail.com>
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 17, 2019
Trott pushed a commit that referenced this pull request Dec 18, 2019
@legendecas @Trott
doc: reference worker threads on signal events
8b5b61a 
PR-URL: #30990
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 18, 2019

Landed in 8b5b61a

@Trott Trott closed this Dec 18, 2019
@legendecas legendecas deleted the doc/signals branch December 19, 2019 15:17
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@legendecas @BridgeAR
doc: reference worker threads on signal events
cc8c0b4 
PR-URL: #30990
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@legendecas @targos
doc: reference worker threads on signal events
7822eb1 
PR-URL: #30990
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@legendecas @BethGriggs
doc: reference worker threads on signal events
d3c9695 
PR-URL: #30990
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@legendecas @Trott @jasnell @addaleax @lpinca @nodejs-github-bot