Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: validate the input data to be of expected types #31030

Closed
wants to merge 2 commits into from
Closed

fs: validate the input data to be of expected types #31030

wants to merge 2 commits into from

Commits on Jan 13, 2020

  1. fs: validate the input data to be of expected types 

    The input was not validated so far and that caused unwanted side
effects. E.g., `undefined` became the string `'undefined'`. It was
expected to fail or to end up as empty string.
Now all input is validated to be either some type of array buffer
view or a string. That way it's always clear what the user intents.

Fixes: nodejs#31025
    @BridgeAR
    BridgeAR committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    385a479 View commit details
    Browse the repository at this point in the history

  2. doc: fs.write is not longer coercing strings

    @juanarbol @BridgeAR
    juanarbol authored and BridgeAR committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    e8940d0 View commit details
    Browse the repository at this point in the history