benchmark: use let instead of var in child_process #31043
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
|
You can work around the error in the benchmark by explicitly allowing zeroes with an environment variable: NODEJS_BENCHMARK_ZERO_ALLOWED=1 node benchmark/run.js child_process |
|
Also, if you don't actually care to run all the benchmarks and just want a quick test that your changes didn't break anything obvious: node test/benchmark/test-benchmark-child-process.js |
Trott
approved these changes
Dec 21, 2019
|
Thanks @Trott . |
BridgeAR
approved these changes
Dec 24, 2019
BridgeAR
added
the
author ready
BridgeAR
pushed a commit
that referenced
this pull request
Dec 25, 2019
PR-URL: #31043 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 3885e15 🎉 |
BridgeAR
pushed a commit
that referenced
this pull request
Jan 3, 2020
PR-URL: #31043 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
targos
pushed a commit
that referenced
this pull request
Jan 14, 2020
PR-URL: #31043 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
PR-URL: #31043 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesI am getting this error here when running benchmarks though:
I ran the benchmark with: