Fs writefile docs update #31104
Closed
Fs writefile docs update #31104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
juanarbol
commented
Dec 26, 2019
doc/api/fs.md
Outdated
| @@ -3982,7 +3982,7 @@ changes: | |||
| * `string` {string} | |||
|
|
|||
| Write `string` to the file specified by `fd`. If `string` is not a string, then | |||
| the value will be coerced to one. | |||
| a exception will be thrown. | |||
There was a problem hiding this comment.
This will be the new behavior, when #31030 get landed.
There was a problem hiding this comment.
Shouldn't this be incorporated into the existing PR instead?
There was a problem hiding this comment.
Thanks for the ping, I'll cherry-pick this in #31030.
@juanarbol please feel free to leave comments in PRs in case you see that something is missing :)
ghost
reviewed
Dec 26, 2019
|
I cherry-picked this into the corresponding PR. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist