Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: make readable & writable computed #31197

Closed
wants to merge 4 commits into from
Closed

stream: make readable & writable computed #31197

wants to merge 4 commits into from

Commits on Jan 29, 2020

  1. stream: make readable & writable computed 

    This makes readable and writable automatically computed based
on the stream state.

Effectivly deprecating/discouraging manual management of this.

Makes the properties  more consistent and easier to reason about.

Fixes: nodejs#29377
    @ronag
    ronag committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    9604c5d View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2020

  1. Apply suggestions from code review 

    Co-Authored-By: Anna Henningsen <github@addaleax.net>
    @ronag @addaleax
    ronag and addaleax authored Feb 1, 2020
    Configuration menu
    Copy the full SHA
    1c5112c View commit details
    Browse the repository at this point in the history

  2. fixup: remove redundant mustCall

    @ronag
    ronag committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    e71ceea View commit details
    Browse the repository at this point in the history

  3. fixup: explicit cast to Boolean

    @ronag
    ronag committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    6160cdb View commit details
    Browse the repository at this point in the history