-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: add Int8Array primordials #31207
lib: add Int8Array primordials #31207
Conversation
Refs: #30697 |
Honestly, it would have been nice to group all the TypedArray PRs into a single one. |
@Sebastien-Ahkrin would it be possible to close a couple of these and to open one PR for all TypedArrays instead? That way it's easier to land these and we have to run less CIs etc. These PRs are pretty straight forward to review and in case you open more: maybe group a couple different ones together as long as they do not exceed e.g. (magic number) 100 changed lines? |
@BridgeAR of course i can do that :) so i will close every typed array PR and reopen in a couple of days |
This needs a rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Sebastien-Ahkrin This needs a rebase |
3353c8e
to
6731423
Compare
8ae28ff
to
2935f72
Compare
Another friendly remainder @Sebastien-Ahkrin |
@antsmartian Sorry :) it's now done ! |
Superseded by #35397 |
Hello,
For this PR I have added Int8Array in the primordials eslint
And i just have created a line in "/lib/.eslintrc.yaml".
And just add Int8Array.
I hope this new PR will help you :x