Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove node::InitializeV8Platform() #31245

Closed
wants to merge 2 commits into from
Closed

src: remove node::InitializeV8Platform() #31245

wants to merge 2 commits into from

Commits on Jan 7, 2020

  1. src: remove uses of node::InitializeV8Platform() 

    This requires minor changes to src/env.cc to deal with
`node::tracing::AgentWriterHandle::GetTracingController()` now possibly
returning a nullptr, because the cctest doesn't set one.

It seems plausible to me that embedders won't set one either so that
seems like an okay change to make. It avoids embedders having to track
down nullptr segfaults.
    @bnoordhuis
    bnoordhuis committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    4013cf1 View commit details
    Browse the repository at this point in the history

  2. src: remove node::InitializeV8Platform() 

    This API method was introduced in commit 90ae4bd ("src: add
InitializeV8Platform function") from July 2018 but wasn't properly
exported and therefore not usable on Windows or with shared library
builds.

The motivation from the commit log is mainly about making it easier
to wire up the cctests and there are better ways to do that.

Refs: nodejs#31217
    @bnoordhuis
    bnoordhuis committed Jan 7, 2020
    Configuration menu
    Copy the full SHA
    3e04100 View commit details
    Browse the repository at this point in the history