Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update JSON header parsing for backticks #31294

Merged
merged 1 commit into from
Jan 12, 2020
Merged

tools: update JSON header parsing for backticks #31294

merged 1 commit into from
Jan 12, 2020

Commits on Jan 12, 2020

  1. tools: update JSON header parsing for backticks 

    Methods, events, and so on in headers in our documentation may (and
should) be set off with backticks in the raw markdown. When that
happens, the headers is misinterpreted by tools/json.js as not being a
method or event. Update the JSON tool generator to accommodate backticks
in this situation and add a test for this situation.

Fixes: nodejs#31290

PR-URL: nodejs#31294
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    @Trott
    Trott committed Jan 12, 2020
    Configuration menu
    Copy the full SHA
    be46a72 View commit details
    Browse the repository at this point in the history