test: fix make test-addons target
#313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I broke the python script in commit edaf7af but because test-all does not run test-addons, it slipped under the radar. Mea culpa. Fixes the following test runner error: Traceback (most recent call last): File "tools/test.py", line 1522, in <module> sys.exit(Main()) File "tools/test.py", line 1454, in Main test_list = root.ListTests([], path, context, arch, mode) File "tools/test.py", line 720, in ListTests test.AddTestsToList(result, full_path, path, context, arch, mode) File "tools/test.py", line 690, in AddTestsToList arch, mode) File "/home/bnoordhuis/src/v1.x/test/gc/../testpy/__init__.py", line 176, in ListTests result.append(SimpleTestCase(test, file_path, mode, self.context, self)) TypeError: __init__() takes at least 7 arguments (6 given) PR-URL: nodejs#313 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
|
LGTM. |
|
I'll add this to CI when merged, currently we're only doing test-simple in CI but I'm open to recommendations for a better config |
|
@rvagg I want to make it part of |
bnoordhuis
force-pushed
the
fix-make-test-addons
branch
from
26c8774
to
dd260d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I broke the python script in commit edaf7af but because test-all does
not run test-addons, it slipped under the radar. Mea culpa.
Fixes the following test runner error:
R=@chrisdickinson