Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: silence warnings from dependencies #31311

Closed
wants to merge 2 commits into from
Closed

build: silence warnings from dependencies #31311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f771f8d
build: silence c-ares Windows compiler warnings
richardlau Jan 11, 2020
307544c
build: silence OpenSSL Windows compiler warnings
richardlau Jan 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion deps/cares/cares.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,10 @@
'defines': [ 'CARES_BUILDING_LIBRARY' ]
}],
[ 'OS=="win"', {
'defines': [ 'CARES_PULL_WS2TCPIP_H=1' ],
'defines': [
'CARES_PULL_WS2TCPIP_H=1',
'_WINSOCK_DEPRECATED_NO_WARNINGS',
],
'include_dirs': [ 'config/win32' ],
'sources': [
'src/config-win32.h',
Expand Down
1 change: 1 addition & 0 deletions deps/openssl/openssl_common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
'cflags': [
'-W3', '-wd4090', '-Gs0', '-GF', '-Gy', '-nologo','/O2',
],
'msvs_disabled_warnings': [4090],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell (setting the msbuild_args=/clp:Verbosity=n environment variable before calling vcbuild to get verbose command lines being passed to cl.exe) the above cflags (containing -wd4090 which should suppress the warning) is being ignored. I've left the cflags alone for now as I can't be sure it isn't used in non-msvs scenarios on Windows (Ninja?).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, OpenSSL's own build configuration ignores the same warning:

node/deps/openssl/openssl/Configurations/10-main.conf

Lines 1199 to 1202 in be055d1

# Note about /wd4090, disable warning C4090. This warning returns false
# positives in some situations. Disabling it altogether masks both
# legitimate and false cases, but as we compile on multiple platforms,
# we rely on other compilers to catch legitimate cases.

'link_settings': {
'libraries': [
'-lws2_32.lib',
Expand Down