doc: fixup changelog for v10.18.1 #31358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BethGriggs
approved these changes
Jan 14, 2020
BridgeAR
approved these changes
Jan 14, 2020
BridgeAR
added
the
author ready
richardlau
approved these changes
Jan 14, 2020
|
Was the missing PR link due to a bug in the changelog maker? |
lpinca
approved these changes
Jan 14, 2020
|
@richardlau, I don't think it was a bug, I think it was because I accidentally labelled 271b413 with |
cjihrig
approved these changes
Jan 14, 2020
Trott
approved these changes
Jan 16, 2020
|
Landed in 5170daa |
Trott
pushed a commit
that referenced
this pull request
Jan 16, 2020
PR-URL: #31358 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 27, 2020
PR-URL: #31358 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
added
dont-land-on-v10.x
and removed
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixup the changelog by adding missing PR link and fix the code block
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes