Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor readline interface test #31423

Closed
wants to merge 4 commits into from
Closed

test: refactor readline interface test #31423

wants to merge 4 commits into from

Commits on Jan 24, 2020

  1. test: refactor test-readline-interface.js 

    This reduces the code lines required to run the tests by abstracting
the constructor call. It also moves tests out of a for loop that
where miss placed.
    @BridgeAR
    BridgeAR committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    4697b73 View commit details
    Browse the repository at this point in the history

  2. test: abstract common assertions in readline-interface test

    @BridgeAR
    BridgeAR committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    6a285f3 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2020

  1. fixup: add another test

    @BridgeAR
    BridgeAR committed Jan 25, 2020
    Configuration menu
    Copy the full SHA
    fe7bdc0 View commit details
    Browse the repository at this point in the history

  2. Revert "fixup: add another test" 

    This reverts commit fe7bdc0.
    @BridgeAR
    BridgeAR committed Jan 25, 2020
    Configuration menu
    Copy the full SHA
    4e84044 View commit details
    Browse the repository at this point in the history