Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitignore: only ignore root Debug directory #3144

Closed
wants to merge 1 commit into from
Closed

gitignore: only ignore root Debug directory #3144

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Oct 1, 2015

On case insensitive platforms, the rule catches the debug module under
npm and eslint and a source directory in next versions of V8.

Ref: #2286 (comment)
Ref: #2688 (comment)

@targos
Copy link
Member Author

targos commented Oct 1, 2015

I can also add the slash to /Release/ for consistency

@Trott
Copy link
Member

Trott commented Oct 1, 2015

LGTM

@silverwind
Copy link
Contributor

LGTM, adding /Release/ is a good idea too.

@targos
gitignore: only ignore root Debug directory
7104c4b 
On case insensitive platforms, the rule catches the debug module under
npm and eslint and a source directory in next versions of V8.
Do the same with the Release directory for consistency.

Ref: nodejs#2286 (comment)
Ref: nodejs#2688 (comment)
PR-URL: nodejs#3144
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@targos
Copy link
Member Author

targos commented Oct 2, 2015

I just did a build on Windows and this is not the right fix, sorry:

> git status
On branch fix-gitignore
Your branch is up-to-date with 'origin/fix-gitignore'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        build/
        deps/gtest/Release/
        deps/http_parser/Release/
        deps/openssl/Release/
        deps/zlib/Release/

nothing added to commit but untracked files present (use "git add" to track)

Looks like we have to keep it without the slash...

@targos
Copy link
Member Author

targos commented Oct 3, 2015

I'll close this and fix the eslint and V8 debug problems separately

@targos targos closed this Oct 3, 2015
@targos targos deleted the fix-gitignore branch January 16, 2016 11:06
@aliscco aliscco mentioned this pull request Jun 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@targos @Trott @silverwind