Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix syntax in N-API documentation #31466

Closed
wants to merge 1 commit into from
Closed

doc: fix syntax in N-API documentation #31466

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Jan 22, 2020
@tniessen
Copy link
Member Author

Please add 👍 here to approve fast-tracking.

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 23, 2020
tniessen added a commit that referenced this pull request Jan 23, 2020
@tniessen
doc: fix syntax in N-API documentation
b4f745e 
PR-URL: #31466
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@tniessen
Copy link
Member Author

Fast-tracking approved, landed in b4f745e. Thanks for reviewing.

@tniessen tniessen closed this Jan 23, 2020
@tniessen tniessen deleted the doc-fix-napi-syntax branch January 23, 2020 03:45
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@tniessen @codebytere
doc: fix syntax in N-API documentation
b1c7458 
PR-URL: #31466
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@tniessen @codebytere
doc: fix syntax in N-API documentation
fa691f8 
PR-URL: #31466
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@tniessen @codebytere
doc: fix syntax in N-API documentation
40480e0 
PR-URL: #31466
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bengl bengl bengl approved these changes

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@cjihrig cjihrig cjihrig approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @bengl @gabrielschulhof @cjihrig @legendecas @nodejs-github-bot