Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add example for tls session resumption #3147

Closed
wants to merge 1 commit into from

Conversation

silverwind
Copy link
Contributor

This came up in #3132. I was assuming this API was still synchronous while it was changed back in 75ea11f. Hopefully this example clears up on how to use TLS session resumption correctly.

cc: @bnoordhuis

@silverwind silverwind added tls Issues and PRs related to the tls subsystem. doc Issues and PRs related to the documentations. labels Oct 1, 2015
Using TLS session resumption correctly is not obvious. This added
example code should help new users understand how to use it correctly.

Related issue: nodejs#3132
@silverwind
Copy link
Contributor Author

Bump! Slightly updated wording and added a commit message. maybe @indutny can review?

@indutny
Copy link
Member

indutny commented Oct 6, 2015

LGTM

silverwind added a commit that referenced this pull request Oct 7, 2015
Using TLS session resumption correctly is not obvious. This added
example code should help new users understand how to use it correctly.

Related issue: #3132
PR-URL: #3147
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
@silverwind
Copy link
Contributor Author

Landed in 07a8419, thanks!

@silverwind silverwind closed this Oct 7, 2015
@silverwind silverwind deleted the doc-tls-session-ids branch October 7, 2015 18:53
@jasnell jasnell mentioned this pull request Oct 8, 2015
29 tasks
silverwind added a commit that referenced this pull request Oct 8, 2015
Using TLS session resumption correctly is not obvious. This added
example code should help new users understand how to use it correctly.

Related issue: #3132
PR-URL: #3147
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants