Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: fix getStringWidth() benchmark #31476

Closed
wants to merge 0 commits into from
Closed

benchmark: fix getStringWidth() benchmark #31476

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 23, 2020

8fb5fe2 broke the benchmark for
getStringWidth(). This fixes it up by updating the argument to
require() to retrieve getStringWidth() from the new internal module
location.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Jan 23, 2020
@Trott
Copy link
Member Author

Trott commented Jan 23, 2020

Chalk one up for the benchmark tests! They legitimately found a broken benchmark this time.

@Trott Trott requested a review from BridgeAR January 23, 2020 14:31
@Trott
Copy link
Member Author

Trott commented Jan 23, 2020

I'd like to fast-track this to fix node-daily-master. Collaborators, 👍 here to approve.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 23, 2020
@Trott
Copy link
Member Author

Trott commented Jan 23, 2020 •
edited
Loading

Benchmark CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/11740/ (queued)

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 23, 2020
Trott added a commit to Trott/io.js that referenced this pull request Jan 23, 2020
@Trott
benchmark: fix getStringWidth() benchmark
085a5c7 
8fb5fe2 broke the benchmark for
getStringWidth(). This fixes it up by updating the argument to
`require()` to retrieve `getStringWidth()` from the new internal module
location.

PR-URL: nodejs#31476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott Trott closed this Jan 23, 2020
@Trott
Copy link
Member Author

Trott commented Jan 23, 2020

Landed in 085a5c7

@Trott Trott deleted the getstringwidth branch January 23, 2020 18:53
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@Trott @codebytere
benchmark: fix getStringWidth() benchmark
b29bada 
8fb5fe2 broke the benchmark for
getStringWidth(). This fixes it up by updating the argument to
`require()` to retrieve `getStringWidth()` from the new internal module
location.

PR-URL: #31476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott @codebytere
benchmark: fix getStringWidth() benchmark
ec06d00 
8fb5fe2 broke the benchmark for
getStringWidth(). This fixes it up by updating the argument to
`require()` to retrieve `getStringWidth()` from the new internal module
location.

PR-URL: #31476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
benchmark: fix getStringWidth() benchmark
393b48e 
8fb5fe2 broke the benchmark for
getStringWidth(). This fixes it up by updating the argument to
`require()` to retrieve `getStringWidth()` from the new internal module
location.

PR-URL: #31476
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @addaleax @cjihrig @nodejs-github-bot