Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove redundant properties from headers #31492

Closed
wants to merge 1 commit into from
Closed

doc: remove redundant properties from headers #31492

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jan 24, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This is not fully tested, just with Firefox on Windows 10. I'll need to rebase it after #31460, I'll do it later

/CC @Trott

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 24, 2020
@Trott
Copy link
Member

Trott commented Jan 24, 2020

This is basically doing what you recommended in #31460 (comment)? I'll take that off my list of things to do if so. :-D

@XhmikosR
Copy link
Contributor Author

Yup :)

I just rebased it, let me know if everything looks the same as in master (which it should).

@XhmikosR XhmikosR marked this pull request as ready for review January 25, 2020 14:24
@Trott
Copy link
Member

Trott commented Jan 26, 2020

Rebased to eliminate the conflict caused by landing #31493.

h5 code,
h6 code {
color: inherit;
font-family: inherit;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

font-family can be removed later too @Trott so that the code is using the same font as everywhere else. AFAICT only the color is needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

font-family can be removed later too @Trott so that the code is using the same font as everywhere else. AFAICT only the color is needed

I thought about doing that in a second commit here, but I want to make sure there aren't any weird kerning issues or anything when we do that. So I was going to save that for another PR. I'm really good at rationalizing dividing CSS changes across multiple PRs apparently. But if you're more confident it won't be a problem, feel free to add it to this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually meant to make it in a separate PR later. Now that the selectors are split, it should be easier to maintain.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 27, 2020
addaleax pushed a commit that referenced this pull request Jan 28, 2020
PR-URL: #31492
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax
Copy link
Member

Landed in 70c32a6 🎉

@addaleax addaleax closed this Jan 28, 2020
@XhmikosR XhmikosR deleted the XhmikosR-patch-1 branch January 28, 2020 15:59
codebytere pushed a commit that referenced this pull request Feb 17, 2020
PR-URL: #31492
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Feb 17, 2020
codebytere pushed a commit that referenced this pull request Mar 15, 2020
PR-URL: #31492
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
PR-URL: #31492
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Mar 17, 2020
codebytere pushed a commit that referenced this pull request Mar 30, 2020
PR-URL: #31492
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants