Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: fix async iterator return when destroyed earlier #31508

Closed
wants to merge 2 commits into from
Closed

stream: fix async iterator return when destroyed earlier #31508

wants to merge 2 commits into from

Commits on Jan 25, 2020

  1. Revert "stream: fix async iterator destroyed error propagation" 

    This reverts commit d15b8ea.
    @mcollina
    mcollina committed Jan 25, 2020
    Configuration menu
    Copy the full SHA
    3df1667 View commit details
    Browse the repository at this point in the history

  2. stream: add regression test for async iteration completion 

    A test was missing for an async iterator created after the stream
had emitted 'close'. This was regressed by nodejs#31314.

See: nodejs#31314
    @mcollina
    mcollina committed Jan 25, 2020
    Configuration menu
    Copy the full SHA
    638ba66 View commit details
    Browse the repository at this point in the history