Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: improve randomBytes() performance #31519

Closed
wants to merge 1 commit into from
Closed

crypto: improve randomBytes() performance #31519

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Jan 26, 2020

Results with included benchmark:

                                           confidence improvement accuracy (*)   (**)  (***)
 crypto/randomBytes.js n=1000 size=1024          ***      8.54 %       ±3.05% ±4.06% ±5.29%
 crypto/randomBytes.js n=1000 size=524288                -0.20 %       ±0.89% ±1.19% ±1.56%
 crypto/randomBytes.js n=1000 size=64            ***     15.77 %       ±1.74% ±2.32% ±3.02%
 crypto/randomBytes.js n=1000 size=8192          ***      3.25 %       ±0.76% ±1.01% ±1.32%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mscdex mscdex added crypto Issues and PRs related to the crypto subsystem. performance Issues and PRs related to the performance of Node.js. labels Jan 26, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28683/

@Trott
Copy link
Member

Trott commented Jan 28, 2020

Landed in 59a1981

@Trott Trott closed this Jan 28, 2020
Trott pushed a commit that referenced this pull request Jan 28, 2020
@mscdex @Trott
crypto: improve randomBytes() performance
59a1981 
PR-URL: #31519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@mscdex mscdex deleted the crypto-improve-randombytes-perf branch January 28, 2020 22:43
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@mscdex @codebytere
crypto: improve randomBytes() performance
3c6545f 
PR-URL: #31519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@mscdex @codebytere
crypto: improve randomBytes() performance
087ad9c 
PR-URL: #31519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@mscdex @codebytere
crypto: improve randomBytes() performance
54da195 
PR-URL: #31519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@mscdex @codebytere
crypto: improve randomBytes() performance
9a3760d 
PR-URL: #31519
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. performance Issues and PRs related to the performance of Node.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mscdex @nodejs-github-bot @Trott @jasnell @tniessen