Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use __executable_start for linux hugepages #31547

Closed
wants to merge 3 commits into from
Closed

src: use __executable_start for linux hugepages #31547

wants to merge 3 commits into from

Commits on Jan 28, 2020

  1. src: use __executable_start for linux hugepages 

    `__executable_start` is provided by GNU's and LLVM's default linker
scripts, obviating the need to plug in a custom linker script.

The problem with our bespoke linker script is that it works with ld.bfd
but not ld.gold and cannot easily be ported because the latter linker
doesn't understand the `INSERT BEFORE` directive.

The /proc/self/maps scanner is updated to account for the fact that
there are a number of sections between `&__executable_start` and
the start of the .text section.

Fortunately, those sections are all mapped into the same memory segment
so we only need to look at the next line to find the start of our text
segment.

Fixes: nodejs#31520
    @bnoordhuis
    bnoordhuis committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    cbf276f View commit details
    Browse the repository at this point in the history

  2. fixup! enable large pages only for executable

    @bnoordhuis
    bnoordhuis committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    569c1e0 View commit details
    Browse the repository at this point in the history

  3. fixup! reinstate freebsd check

    @bnoordhuis
    bnoordhuis committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    6d38519 View commit details
    Browse the repository at this point in the history