Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve flaky http2-stream-destroy-event-order #31590

Closed

Commits on Jan 31, 2020

  1. test: improve flaky http2-stream-destroy-event-order

    This doesn't properly fix the issue, it only significantly reduces
    (removes?) the flakiness of the test.
    
    The setTimeout must not be needed here. Specifically if the settings
    frame on the client is 'delayed' and only comes after we have already
    called `req.close(2)` then the 'close' event will be emitted before the
    stream has got a chance to write the rst to the underlying socket (even
    though FlushRstStream and SendPendingData have been called) and since we
    are destroying a session here it will never be written resulting in a
    'clean' stream close on the server side and therefore a timeout because
    there will be no error.
    lundibundi committed Jan 31, 2020
    Configuration menu
    Copy the full SHA
    5c0eab9 View commit details
    Browse the repository at this point in the history