benchmark: use let instead of var

benchmark/module/module-loader-deep.js

@@ -19,7 +19,7 @@ function main({ ext, cache, files }) {
     `${benchmarkDirectory}/a.js`,
     'module.exports = {};'
   );
-  for (var i = 0; i <= files; i++) {
+  for (let i = 0; i <= files; i++) {
     fs.mkdirSync(`${benchmarkDirectory}/${i}`);
     fs.writeFileSync(
       `${benchmarkDirectory}/${i}/package.json`,
@@ -37,14 +37,13 @@ function main({ ext, cache, files }) {
 }
 
 function measureDir(cache, files) {
-  var i;
   if (cache) {
-    for (i = 0; i <= files; i++) {
+    for (let i = 0; i <= files; i++) {
       require(`${benchmarkDirectory}/${i}`);
     }
   }
   bench.start();
-  for (i = 0; i <= files; i++) {
+  for (let i = 0; i <= files; i++) {
     require(`${benchmarkDirectory}/${i}`);
   }
   bench.end(files);

benchmark/module/module-loader.js

@@ -21,7 +21,7 @@ const bench = common.createBenchmark(main, {
 function main({ n, name, cache, files, dir }) {
   tmpdir.refresh();
   fs.mkdirSync(benchmarkDirectory);
-  for (var i = 0; i <= files; i++) {
+  for (let i = 0; i <= files; i++) {
     fs.mkdirSync(`${benchmarkDirectory}${i}`);
     fs.writeFileSync(
       `${benchmarkDirectory}${i}/package.json`,
@@ -42,15 +42,14 @@ function main({ n, name, cache, files, dir }) {
 }
 
 function measureDir(n, cache, files, name) {
-  var i;
   if (cache) {
-    for (i = 0; i <= files; i++) {
+    for (let i = 0; i <= files; i++) {
       require(`${benchmarkDirectory}${i}${name}`);
     }
   }
   bench.start();
-  for (i = 0; i <= files; i++) {
-    for (var j = 0; j < n; j++)
+  for (let i = 0; i <= files; i++) {
+    for (let j = 0; j < n; j++)
       require(`${benchmarkDirectory}${i}${name}`);
     // Pretend mixed input (otherwise the results are less representative due to
     // highly specialized code).

benchmark/napi/function_args/index.js

@@ -89,7 +89,7 @@ function main({ n, engine, type }) {
     const args = generateArgs(type);
 
     bench.start();
-    for (var i = 0; i < n; i++) {
+    for (let i = 0; i < n; i++) {
       fn.apply(null, args);
     }
     bench.end(n);

benchmark/napi/function_call/index.js

@@ -29,7 +29,7 @@ try {
 }
 const napi = napi_binding.hello;
 
-var c = 0;
+let c = 0;
 function js() {
   return c++;
 }
@@ -44,7 +44,7 @@ const bench = common.createBenchmark(main, {
 function main({ n, type }) {
   const fn = type === 'cxx' ? cxx : type === 'napi' ? napi : js;
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     fn();
   }
   bench.end(n);

benchmark/net/net-c2s-cork.js

@@ -11,8 +11,8 @@ const bench = common.createBenchmark(main, {
   dur: [5],
 });
 
-var chunk;
-var encoding;
+let chunk;
+let encoding;
 
 function main({ dur, len, type }) {
   switch (type) {

benchmark/net/net-c2s.js

@@ -11,8 +11,8 @@ const bench = common.createBenchmark(main, {
   dur: [5],
 });
 
-var chunk;
-var encoding;
+let chunk;
+let encoding;
 
 function main({ dur, len, type }) {
   switch (type) {

benchmark/net/net-pipe.js

@@ -11,8 +11,8 @@ const bench = common.createBenchmark(main, {
   dur: [5],
 });
 
-var chunk;
-var encoding;
+let chunk;
+let encoding;
 
 function main({ dur, len, type }) {
   switch (type) {

benchmark/net/net-s2c.js

@@ -12,10 +12,10 @@ const bench = common.createBenchmark(main, {
   dur: [5]
 });
 
-var chunk;
-var encoding;
-var recvbuf;
-var received = 0;
+let chunk;
+let encoding;
+let recvbuf;
+let received = 0;
 
 function main({ dur, sendchunklen, type, recvbuflen, recvbufgenfn }) {
   if (isFinite(recvbuflen) && recvbuflen > 0)
@@ -38,8 +38,8 @@ function main({ dur, sendchunklen, type, recvbuflen, recvbufgenfn }) {
   }
 
   const reader = new Reader();
-  var writer;
-  var socketOpts;
+  let writer;
+  let socketOpts;
   if (recvbuf === undefined) {
     writer = new Writer();
     socketOpts = { port: PORT };

benchmark/net/net-wrap-js-stream-passthrough.js

@@ -12,8 +12,8 @@ const bench = common.createBenchmark(main, {
   flags: ['--expose-internals']
 });
 
-var chunk;
-var encoding;
+let chunk;
+let encoding;
 
 function main({ dur, len, type }) {
   // Can only require internals inside main().

benchmark/net/tcp-raw-c2s.js

@@ -24,7 +24,7 @@ function main({ dur, len, type }) {
   const PORT = common.PORT;
 
   const serverHandle = new TCP(TCPConstants.SERVER);
-  var err = serverHandle.bind('127.0.0.1', PORT);
+  let err = serverHandle.bind('127.0.0.1', PORT);
   if (err)
     fail(err, 'bind');
 
@@ -38,7 +38,7 @@ function main({ dur, len, type }) {
 
     // The meat of the benchmark is right here:
     bench.start();
-    var bytes = 0;
+    let bytes = 0;
 
     setTimeout(() => {
       // report in Gb/sec
@@ -67,7 +67,7 @@ function main({ dur, len, type }) {
   }
 
   function client(type, len) {
-    var chunk;
+    let chunk;
     switch (type) {
       case 'buf':
         chunk = Buffer.alloc(len, 'x');
@@ -102,7 +102,7 @@ function main({ dur, len, type }) {
     function write() {
       const writeReq = new WriteWrap();
       writeReq.oncomplete = afterWrite;
-      var err;
+      let err;
       switch (type) {
         case 'buf':
           err = clientHandle.writeBuffer(writeReq, chunk);

benchmark/net/tcp-raw-pipe.js

@@ -31,7 +31,7 @@ function main({ dur, len, type }) {
 
   // Server
   const serverHandle = new TCP(TCPConstants.SERVER);
-  var err = serverHandle.bind('127.0.0.1', PORT);
+  let err = serverHandle.bind('127.0.0.1', PORT);
   if (err)
     fail(err, 'bind');
 
@@ -66,7 +66,7 @@ function main({ dur, len, type }) {
   };
 
   // Client
-  var chunk;
+  let chunk;
   switch (type) {
     case 'buf':
       chunk = Buffer.alloc(len, 'x');
@@ -83,7 +83,7 @@ function main({ dur, len, type }) {
 
   const clientHandle = new TCP(TCPConstants.SOCKET);
   const connectReq = new TCPConnectWrap();
-  var bytes = 0;
+  let bytes = 0;
 
   err = clientHandle.connect(connectReq, '127.0.0.1', PORT);
   if (err)
@@ -118,7 +118,7 @@ function main({ dur, len, type }) {
   function write() {
     const writeReq = new WriteWrap();
     writeReq.oncomplete = afterWrite;
-    var err;
+    let err;
     switch (type) {
       case 'buf':
         err = clientHandle.writeBuffer(writeReq, chunk);

benchmark/net/tcp-raw-s2c.js

@@ -26,7 +26,7 @@ function main({ dur, len, type }) {
   const PORT = common.PORT;
 
   const serverHandle = new TCP(TCPConstants.SERVER);
-  var err = serverHandle.bind('127.0.0.1', PORT);
+  let err = serverHandle.bind('127.0.0.1', PORT);
   if (err)
     fail(err, 'bind');
 
@@ -38,7 +38,7 @@ function main({ dur, len, type }) {
     if (err)
       fail(err, 'connect');
 
-    var chunk;
+    let chunk;
     switch (type) {
       case 'buf':
         chunk = Buffer.alloc(len, 'x');
@@ -62,7 +62,7 @@ function main({ dur, len, type }) {
       const writeReq = new WriteWrap();
       writeReq.async = false;
       writeReq.oncomplete = afterWrite;
-      var err;
+      let err;
       switch (type) {
         case 'buf':
           err = clientHandle.writeBuffer(writeReq, chunk);
@@ -108,7 +108,7 @@ function main({ dur, len, type }) {
       fail(err, 'connect');
 
     connectReq.oncomplete = function() {
-      var bytes = 0;
+      let bytes = 0;
       clientHandle.onread = function(buffer) {
         // We're not expecting to ever get an EOF from the client.
         // Just lots of data forever.

benchmark/os/cpus.js

@@ -9,7 +9,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n }) {
   bench.start();
-  for (var i = 0; i < n; ++i)
+  for (let i = 0; i < n; ++i)
     cpus();
   bench.end(n);
 }

benchmark/os/loadavg.js

@@ -9,7 +9,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n }) {
   bench.start();
-  for (var i = 0; i < n; ++i)
+  for (let i = 0; i < n; ++i)
     loadavg();
   bench.end(n);
 }

benchmark/os/networkInterfaces.js

@@ -9,7 +9,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n }) {
   bench.start();
-  for (var i = 0; i < n; ++i)
+  for (let i = 0; i < n; ++i)
     networkInterfaces();
   bench.end(n);
 }

benchmark/path/basename-posix.js

@@ -19,15 +19,15 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ n, pathext }) {
-  var ext;
+  let ext;
   const extIdx = pathext.indexOf('|');
   if (extIdx !== -1) {
     ext = pathext.slice(extIdx + 1);
     pathext = pathext.slice(0, extIdx);
   }
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     posix.basename(i % 3 === 0 ? `${pathext}${i}` : pathext, ext);
   }
   bench.end(n);

benchmark/path/basename-win32.js

@@ -19,15 +19,15 @@ const bench = common.createBenchmark(main, {
 });
 
 function main({ n, pathext }) {
-  var ext;
+  let ext;
   const extIdx = pathext.indexOf('|');
   if (extIdx !== -1) {
     ext = pathext.slice(extIdx + 1);
     pathext = pathext.slice(0, extIdx);
   }
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     win32.basename(i % 3 === 0 ? `${pathext}${i}` : pathext, ext);
   }
   bench.end(n);

benchmark/path/dirname-posix.js

@@ -17,7 +17,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     posix.dirname(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

benchmark/path/dirname-win32.js

@@ -17,7 +17,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     win32.dirname(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

benchmark/path/extname-posix.js

@@ -20,7 +20,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     posix.extname(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

benchmark/path/extname-win32.js

@@ -20,7 +20,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     win32.extname(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

benchmark/path/format-posix.js

@@ -20,7 +20,7 @@ function main({ n, props }) {
   };
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     obj.base = `a${i}${props[2] || ''}`;
     obj.name = `a${i}${props[4] || ''}`;
     posix.format(obj);

benchmark/path/format-win32.js

@@ -20,7 +20,7 @@ function main({ n, props }) {
   };
 
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     obj.base = `a${i}${props[2] || ''}`;
     obj.name = `a${i}${props[4] || ''}`;
     win32.format(obj);

benchmark/path/isAbsolute-posix.js

@@ -15,7 +15,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     posix.isAbsolute(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);

benchmark/path/isAbsolute-win32.js

@@ -16,7 +16,7 @@ const bench = common.createBenchmark(main, {
 
 function main({ n, path }) {
   bench.start();
-  for (var i = 0; i < n; i++) {
+  for (let i = 0; i < n; i++) {
     win32.isAbsolute(i % 3 === 0 ? `${path}${i}` : path);
   }
   bench.end(n);