Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readline: add error handling for input stream #31603

Closed
wants to merge 1 commit into from

Commits on Nov 21, 2020

  1. lib: add error handling for input stream

    This adds support for error handling in readline.createInterface()
    for cases where the input object is not supplied, the input stream
    is invalid, or the underlying buffer emits an error.
    
    Now, the 'error' emissions by the readline module are thrown but
    in order to log those in the specific case of await for loops,
    we still need to fix silent rejections (TODO added there) inside
    async iterators for the thenables to work.
    
    Fixes: nodejs#30831
    rexagod committed Nov 21, 2020
    Configuration menu
    Copy the full SHA
    4cacd55 View commit details
    Browse the repository at this point in the history