Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark additional tests as flaky on Windows #31606

Closed
wants to merge 1 commit into from
Closed

test: mark additional tests as flaky on Windows #31606

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Feb 1, 2020

Basically, any of the tests that failed in the runs for
#31602 which was not already
marked as flaky.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
test: mark additional tests as flaky on Windows
881d533 
Basically, any of the tests that failed in the runs for
nodejs#31602 which was not already
marked as flaky.
@addaleax addaleax added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Feb 1, 2020
@nodejs-github-bot nodejs-github-bot added async_hooks Issues and PRs related to the async hooks subsystem. test Issues and PRs related to the tests. labels Feb 1, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/28860/

@addaleax
Copy link
Member Author

addaleax commented Feb 1, 2020

Please 👍 this comment to approve fast-tracking, CI isn’t in a great state right now and this would make the number of failures a bit easier to deal with.

@addaleax addaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 1, 2020
addaleax added a commit that referenced this pull request Feb 1, 2020
@addaleax
test: mark additional tests as flaky on Windows
9528f95 
Basically, any of the tests that failed in the runs for
#31602 which was not already
marked as flaky.

PR-URL: #31606
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@addaleax
Copy link
Member Author

addaleax commented Feb 1, 2020

Landed in 9528f95, thanks for the reviews!

@addaleax addaleax closed this Feb 1, 2020
@addaleax addaleax deleted the win-flaky branch February 1, 2020 22:00
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@addaleax @codebytere
test: mark additional tests as flaky on Windows
c3247fe 
Basically, any of the tests that failed in the runs for
#31602 which was not already
marked as flaky.

PR-URL: #31606
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@addaleax @codebytere
test: mark additional tests as flaky on Windows
8997ee7 
Basically, any of the tests that failed in the runs for
#31602 which was not already
marked as flaky.

PR-URL: #31606
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@addaleax @codebytere
test: mark additional tests as flaky on Windows
8c5fd5a 
Basically, any of the tests that failed in the runs for
#31602 which was not already
marked as flaky.

PR-URL: #31606
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@addaleax @codebytere
test: mark additional tests as flaky on Windows
0eb2dbb 
Basically, any of the tests that failed in the runs for
#31602 which was not already
marked as flaky.

PR-URL: #31606
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@addaleax @nodejs-github-bot @joyeecheung @richardlau