Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify Worker exit/message event ordering #31642

Closed
wants to merge 1 commit into from
Closed

doc: clarify Worker exit/message event ordering #31642

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Feb 5, 2020

Motivated by the fact that getting this wrong has led to flaky
tests in our test suite.

Refs: #31637

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax
doc: clarify Worker exit/message event ordering
88ee115 
Motivated by the fact that getting this wrong has led to flaky
tests in our test suite.

Refs: nodejs#31637
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support. labels Feb 5, 2020
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 7, 2020
addaleax added a commit that referenced this pull request Feb 7, 2020
@addaleax
doc: clarify Worker exit/message event ordering
7df4298 
Motivated by the fact that getting this wrong has led to flaky
tests in our test suite.

Refs: #31637

PR-URL: #31642
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax
Copy link
Member Author

addaleax commented Feb 7, 2020

Landed in 7df4298

@addaleax addaleax closed this Feb 7, 2020
codebytere pushed a commit that referenced this pull request Feb 17, 2020
@addaleax @codebytere
doc: clarify Worker exit/message event ordering
77ec381 
Motivated by the fact that getting this wrong has led to flaky
tests in our test suite.

Refs: #31637

PR-URL: #31642
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@addaleax @codebytere
doc: clarify Worker exit/message event ordering
9b0249a 
Motivated by the fact that getting this wrong has led to flaky
tests in our test suite.

Refs: #31637

PR-URL: #31642
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@addaleax @codebytere
doc: clarify Worker exit/message event ordering
8dfa3fe 
Motivated by the fact that getting this wrong has led to flaky
tests in our test suite.

Refs: #31637

PR-URL: #31642
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@addaleax @codebytere
doc: clarify Worker exit/message event ordering
28657cc 
Motivated by the fact that getting this wrong has led to flaky
tests in our test suite.

Refs: #31637

PR-URL: #31642
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @jasnell @cjihrig @gireeshpunathil @nodejs-github-bot