Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: fixup collaborator list errors #31655

Closed
wants to merge 1 commit into from
Closed

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 6, 2020

Missing - characters in the list

Checklist

Missing `-` characters in the list
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 6, 2020
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some other PR: We should probably make all of these one line rather than wrapping them into two lines. The line wrapping makes the markdown harder to read and has no tangible benefit that I'm aware of. Would probably need to disable a markdown lint rule with a comment or something but that should be it, I think.

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 6, 2020
@jasnell
Copy link
Member Author

jasnell commented Feb 6, 2020

👍 to fast-track

@cjihrig
Copy link
Contributor

cjihrig commented Feb 6, 2020

Would probably need to disable a markdown lint rule with a comment or something but that should be it, I think.

Might be overkill, but we could consider a linting rule for these collaborator lists. This is far from the first time there has been a formatting/ordering issue in them.

@Trott
Copy link
Member

Trott commented Feb 6, 2020

Landed in e001710

@Trott Trott closed this Feb 6, 2020
Trott pushed a commit that referenced this pull request Feb 6, 2020
Add missing `-` characters in the list.

PR-URL: #31655
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit that referenced this pull request Feb 17, 2020
Add missing `-` characters in the list.

PR-URL: #31655
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Feb 17, 2020
@devsnek devsnek deleted the fixup-collaborator-list branch February 19, 2020 06:59
codebytere pushed a commit that referenced this pull request Mar 15, 2020
Add missing `-` characters in the list.

PR-URL: #31655
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
Add missing `-` characters in the list.

PR-URL: #31655
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
codebytere pushed a commit that referenced this pull request Mar 30, 2020
Add missing `-` characters in the list.

PR-URL: #31655
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants