test: remove arguments.callee usage #3167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arguments.callee is forbidden in strict mode and the fact that it's being used masked a possible error in this test.
|
Change LGTM, I am okay if the CI is okay. |
|
CI: https://ci.nodejs.org/job/node-test-pull-request/412/ For the record, this change should've been done when we turned all tests into strict mode, pretty much an oversight on my part. |
|
@silverwind Mmmm yeah. But how it was not failing the builds till now? |
|
@thefourtheye because it only errors when it reaches a failure condition. If the test passes, the strict mode warning is never reached. What we have here, is a masked error on the linked test. |
|
FWIW: this is the only remaining use of |
|
LGTM, failures are unrelated. |
|
LGTM |
silverwind
added a commit
that referenced
this pull request
Oct 5, 2015
arguments.callee is forbidden in strict mode and the fact that it's being used masked a possible error in this test. PR-URL: #3167 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
|
Thanks, landed in 342c3a1. |
silverwind
added a commit
that referenced
this pull request
Oct 8, 2015
arguments.callee is forbidden in strict mode and the fact that it's being used masked a possible error in this test. PR-URL: #3167 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arguments.calleeis forbidden in strict mode and the fact that it's being used masked a possible error in this test like in this case:https://ci.nodejs.org/job/node-test-binary-arm/101/RUN_SUBSET=0,nodes=pi1-raspbian-wheezy/tapTestReport/test.tap-39/