doc: improve strict assertion mode color text #31703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
BridgeAR
approved these changes
Feb 9, 2020
BridgeAR
added
the
author ready
addaleax
approved these changes
Feb 9, 2020
cjihrig
approved these changes
Feb 9, 2020
jasnell
approved these changes
Feb 10, 2020
Minor improvements to the text about colors in strict assertion mode: * Consolidate the two paragraphs into one * Pluralize "variables" * Remove unnecessary article "the" * Change "doc" to "documentation" PR-URL: nodejs#31703 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 7e38629 |
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
Minor improvements to the text about colors in strict assertion mode: * Consolidate the two paragraphs into one * Pluralize "variables" * Remove unnecessary article "the" * Change "doc" to "documentation" PR-URL: #31703 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
Minor improvements to the text about colors in strict assertion mode: * Consolidate the two paragraphs into one * Pluralize "variables" * Remove unnecessary article "the" * Change "doc" to "documentation" PR-URL: #31703 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
Minor improvements to the text about colors in strict assertion mode: * Consolidate the two paragraphs into one * Pluralize "variables" * Remove unnecessary article "the" * Change "doc" to "documentation" PR-URL: #31703 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
Minor improvements to the text about colors in strict assertion mode: * Consolidate the two paragraphs into one * Pluralize "variables" * Remove unnecessary article "the" * Change "doc" to "documentation" PR-URL: #31703 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvements to the text about colors in strict assertion mode:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes