Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix few comment typos in fs/watchers.js #31705

Closed
wants to merge 3 commits into from
Closed

lib: fix few comment typos in fs/watchers.js #31705

wants to merge 3 commits into from

Conversation

lundibundi
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Feb 9, 2020
Trott
Trott reviewed Feb 9, 2020
View reviewed changes
lib/internal/fs/watchers.js Outdated Show resolved Hide resolved
Trott
Trott reviewed Feb 9, 2020
View reviewed changes
lib/internal/fs/watchers.js Outdated Show resolved Hide resolved
lundibundi and others added 2 commits February 9, 2020 13:20
@lundibundi @Trott
fixup! Update lib/internal/fs/watchers.js
d7cdfca 
Co-Authored-By: Rich Trott <rtrott@gmail.com>
@lundibundi @Trott
fixup! Update lib/internal/fs/watchers.js
926b247 
Co-Authored-By: Rich Trott <rtrott@gmail.com>
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 9, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29053/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29087/

addaleax pushed a commit that referenced this pull request Feb 13, 2020
@lundibundi @addaleax
lib: fix few comment typos in fs/watchers.js
bc55b57 
PR-URL: #31705
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax
Copy link
Member

Landed in bc55b57

@addaleax addaleax closed this Feb 13, 2020
@lundibundi lundibundi deleted the few-comment-typo-fixes-watcher branch February 13, 2020 20:27
@codebytere
Copy link
Member

@lundibundi should this go back to v13.x? It'll need a manual backport if yes.

@lundibundi
Copy link
Member Author

I don't think it is needed unless it will help with other conflicts.

@BethGriggs BethGriggs mentioned this pull request Apr 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@antsmartian antsmartian antsmartian approved these changes

@cjihrig cjihrig cjihrig approved these changes

@devnexen devnexen devnexen approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.