Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: prefer 3-argument Array::New() #31775

Closed
wants to merge 2 commits into from
Closed

src: prefer 3-argument Array::New() #31775

wants to merge 2 commits into from

Commits on Feb 13, 2020

  1. src: prefer 3-argument Array::New() 

    This is nicer, because:

1. It reduces overall code size,
2. It’s faster, because `Object::Set()` calls are relatively slow, and
3. It helps avoid invalid `.Check()`/`.FromJust()` calls.
    @addaleax
    addaleax committed Feb 13, 2020
    Configuration menu
    Copy the full SHA
    d942aa9 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. fixup! src: prefer 3-argument Array::New() 

    Co-Authored-By: Ben Noordhuis <info@bnoordhuis.nl>
    @addaleax @bnoordhuis
    addaleax and bnoordhuis authored Feb 14, 2020
    Configuration menu
    Copy the full SHA
    72c5cf9 View commit details
    Browse the repository at this point in the history