Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v13.9.0 proposal #31837

Merged
merged 221 commits into from
Feb 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
221 commits
Select commit Hold shift + click to select a range
13c6965
src: ignore GCC -Wcast-function-type for v8.h
danbev Jan 23, 2020
83dd65a
src: fix ignore GCC -Wcast-function-type for older compilers
lundibundi Jan 26, 2020
2e216ae
build: do not use setup-node in build workflows
richardlau Jan 14, 2020
91f5e9b
doc: document missing properties in child_process
HarshithaKP Jan 13, 2020
bd54abe
doc: explain _writev() API
HarshithaKP Jan 14, 2020
6833f62
test: add promises metadata to postmortem test
mmarchini Jan 14, 2020
6055134
doc: explain `hex` encoding in Buffer API
HarshithaKP Jan 14, 2020
5bd3f6c
deps,test: update to uvwasi 0.0.4
cjihrig Jan 15, 2020
00e38a7
deps: port uvwasi@676ba9a to gyp
cjihrig Jan 15, 2020
7c4f1ed
deps: uvwasi: cherry-pick 941bedf
cjihrig Jan 17, 2020
1e08d3c
doc: correct added version for --abort-on-uncaught-exception
addaleax Jan 14, 2020
d770998
doc: fix a broken link in fs.md
himself65 Jan 15, 2020
0bafb5c
test: export public symbols in addons tests
bnoordhuis Jan 12, 2020
32ac1be
fs: unset FileHandle fd after close
addaleax Jan 16, 2020
6256d0a
test: update postmortem test with v12 constants
mmarchini Jan 16, 2020
b8face2
src: reduce large pages code duplication
Jan 16, 2020
843c5c6
doc: fix several child_process doc typos
cjihrig Jan 17, 2020
2c2b3ba
fs: do not emit 'close' twice if emitClose enabled
ronag Jan 16, 2020
099c921
test: add wasi test for symlink() and readlink()
cjihrig Jan 18, 2020
1099524
doc: document process.std*.fd
HarshithaKP Jan 17, 2020
572322f
crypto: add key type 'dh'
tniessen Dec 29, 2019
15bd2c9
crypto: simplify DH groups
tniessen Dec 31, 2019
0d3e095
crypto: add DH support to generateKeyPair
tniessen Dec 31, 2019
bf46c30
crypto: add crypto.diffieHellman
tniessen Jan 3, 2020
676b84a
test: skip keygen tests on arm systems
tniessen Jan 20, 2020
583d1d9
test: improve wasi stat test
cjihrig Jan 19, 2020
7ecf842
lib,src: switch Buffer::kMaxLength to size_t
bnoordhuis Jan 18, 2020
53e566b
src: better encapsulate native immediate list
addaleax Dec 16, 2019
74a7cdb
src: exclude C++ SetImmediate() from count
addaleax Jan 15, 2020
600e96e
src: add a threadsafe variant of SetImmediate()
addaleax Jan 15, 2020
f8c45b2
src: remove AsyncRequest
addaleax Jan 15, 2020
0cacc1f
src: add interrupts to Environments/Workers
addaleax Jan 16, 2020
f56de5a
src: move MemoryInfo() for worker code to .cc files
addaleax Jan 16, 2020
1bcf2f9
report: add support for Workers
addaleax Jan 16, 2020
3da4d51
util: improve unicode support
BridgeAR Jan 11, 2020
5656ec9
worker: move JoinThread() back into exit callback
addaleax Jan 22, 2020
049a172
src: harden running native `SetImmediate()`s slightly
addaleax Jan 22, 2020
67d8967
doc: add explanatory to path.resolve description
YakovL Jan 20, 2020
b1c7458
doc: fix syntax in N-API documentation
tniessen Jan 22, 2020
e46cfaf
errors: make use of "cannot" consistent
tniessen Jan 20, 2020
c2792aa
test: remove bluebird remnants from test fixture
Trott Jan 21, 2020
6797656
module: revert #31021
GeoffreyBooth Jan 19, 2020
ca81af7
module: correct docs about when extensionless files are supported
GeoffreyBooth Jan 19, 2020
aa26662
module: drop support for extensionless main entry points in esm
GeoffreyBooth Jan 20, 2020
04f2799
deps: update to uvwasi 0.0.5
cjihrig Jan 20, 2020
09566be
deps: uvwasi: cherry-pick ea73af5
cjihrig Jan 21, 2020
2fe0ed3
deps: uvwasi: cherry-pick c3bef8e
cjihrig Jan 22, 2020
9811ebe
deps: uvwasi: cherry-pick eea4508
cjihrig Jan 22, 2020
38ea536
test: add wasi test for freopen()
cjihrig Jan 18, 2020
03aac4e
tls: simplify errors using ThrowCryptoError
tniessen Jan 21, 2020
b29bada
benchmark: fix getStringWidth() benchmark
Trott Jan 23, 2020
4591202
crypto: assign and use ERR_CRYPTO_UNKNOWN_CIPHER
tniessen Jan 20, 2020
f84b34d
crypto: improve errors in DiffieHellmanGroup
tniessen Jan 21, 2020
a685827
src: add C++-style sprintf utility
addaleax Jan 21, 2020
76aad0e
src: use custom fprintf alike to write errors to stderr
addaleax Jan 21, 2020
e9462b4
doc: fix code display in header glitch
Trott Jan 22, 2020
b25ea9b
test: add tests for main() argument handling
cjihrig Jan 20, 2020
15b24b7
doc: add ronag to collaborators
ronag Jan 24, 2020
729b961
doc: further fix async iterator example
ronag Jan 15, 2020
5e1bee8
util: fix inspection of typed arrays with unusual length
BridgeAR Jan 21, 2020
f2dc694
test: fix test-heapdump-worker
addaleax Jan 24, 2020
9e9dbd4
src: reduce code duplication in BootstrapNode
lundibundi Jan 22, 2020
bc0c142
src: define noreturn attribute for windows
lxbndr Jan 22, 2020
464f4af
deps: upgrade to libuv 1.34.2
cjihrig Jan 23, 2020
8f25e51
doc: clean up and streamline vm.md examples
lundibundi Jan 23, 2020
c4a2f94
test: cover property n-api null cases
Jan 23, 2020
f75fe9a
doc: enable visual code indication in headers
Trott Jan 24, 2020
20d0a0e
stream: add async iterator support for v1 streams
ronag Jan 11, 2020
5a95fa4
stream: normalize async iterator stream destroy
ronag Jan 11, 2020
3046648
stream: implement throw for async iterator
ronag Jan 11, 2020
2eeaa5c
deps: uvwasi: cherry-pick 7b5b6f9
cjihrig Jan 24, 2020
bf7097c
deps: switch to chromium's zlib implementation
mscdex Jan 6, 2020
9d45393
buffer: improve fill(number) performance
mscdex Jan 24, 2020
cd75433
process: fix two overflow cases in SourceMap VLQ decoding
jridgewell Jan 24, 2020
a2b7006
build: build docs in GitHub Actions CI workflow
richardlau Jan 24, 2020
8669ecc
fs: bail on permission error in recursive directory creation
bcoe Jan 25, 2020
07525c3
test: make test-http2-buffersize more correct
addaleax Jan 25, 2020
ef4d081
src: simplify native immediate queue running
addaleax Jan 25, 2020
3dd4089
src,lib: make ^C print a JS stack trace
legendecas Aug 19, 2019
3c6545f
crypto: improve randomBytes() performance
mscdex Jan 26, 2020
9ecae58
lib: delete dead code in SourceMap
jridgewell Jan 25, 2020
04d783a
doc: update maintaining-V8.md
kzs0 Jan 25, 2020
a52df55
doc: remove redundant properties from headers
XhmikosR Jan 22, 2020
f255053
stream: fix finished writable/readable state
ronag Jan 26, 2020
f04576e
src: fix debug crash handling null strings
rustyconover Jan 26, 2020
769154d
buffer: improve concat() performance
mscdex Jan 26, 2020
eb3c6e9
benchmark: use let and const instead of var
dnlup Jan 24, 2020
39c86bb
tools: replace deprecated iteritems() for items()
Gioyik Jan 26, 2020
538582b
Revert "stream: fix async iterator destroyed error propagation"
mcollina Jan 25, 2020
80e75ab
stream: add regression test for async iteration completion
mcollina Jan 25, 2020
43186e0
doc: change error message testing policy
tniessen Jan 20, 2020
4152428
test,benchmark: fix test-benchmark-zlib
Trott Jan 27, 2020
c167ae0
src: fix minor typo in base_object.h
danbev Jan 27, 2020
e2b3e4e
doc: update collaborator guide citgm instructions
ronag Jan 28, 2020
4cac2cc
doc: simultaneous blog and email of sec announce
sam-github Jan 23, 2020
cde4b51
doc: update job reference in COLLABORATOR_GUIDE.md
richardlau Jan 28, 2020
6fdef45
worker: remove redundant closing of child port
aaccttrr Jan 28, 2020
6723156
process: report ArrayBuffer memory in `memoryUsage()`
addaleax Jan 28, 2020
6626c4d
doc: clarify that `v8.serialize()` is not deterministic
addaleax Jan 28, 2020
c821569
n-api: rename 'promise' parameter to 'value'
tniessen Jan 28, 2020
03eade0
build: enable loading internal modules from disk
devsnek Jan 11, 2020
5a12cd6
test: remove --experimental-worker flag comment
HarshithaKP Jan 29, 2020
7fe9d5e
doc: add protocol option in http2.connect()
murgatroid99 Jan 29, 2020
0ac124b
deps: upgrade npm to 6.13.7
Jan 28, 2020
2638110
doc: clarify require() OS independence
lundibundi Jan 29, 2020
6d5c3cd
src: remove preview for heap dump utilities
addaleax Jan 29, 2020
10f9abe
build: ignore all the "Debug","Release" folders
DavenportEmma Jan 29, 2020
23da559
test: verify threadId in reports
Jan 28, 2020
ebdcafa
benchmark: add MessagePort benchmark
addaleax Jan 29, 2020
faec87b
doc: list largepage values in --help
cjihrig Jan 27, 2020
3ba0a22
doc: clarify socket.setNoDelay() explanation
rustyconover Jan 27, 2020
f402649
doc: fix numbering
Nef10 Jan 30, 2020
277980d
src: use __executable_start for linux hugepages
bnoordhuis Jan 28, 2020
3fdec1c
test: fix flaky test-memory-usage
addaleax Feb 1, 2020
c3247fe
test: mark additional tests as flaky on Windows
addaleax Feb 1, 2020
49be500
test: show child stderr output in largepages test
bnoordhuis Feb 2, 2020
9fd1e71
src: fix console debug output on Windows
lundibundi Jan 30, 2020
42b8354
src: remove duplicate field env in CryptoJob class
DavenportEmma Jan 28, 2020
62d0c60
test: simplify test-https-simple.js
sam-github May 29, 2019
6fe8eda
benchmark: clean up config resolution in multiple benchmarks
lundibundi Jan 30, 2020
8d3ffbe
worker: add ability to take heap snapshot from parent thread
addaleax Jan 29, 2020
f6392e9
esm: import.meta.resolve with nodejs: builtins
guybedford Dec 19, 2019
43e2c2e
src: change Fill() to use ParseArrayIndex()
DavenportEmma Jan 30, 2020
7c3cc94
test: unset NODE_OPTIONS for cctest
addaleax Jan 31, 2020
21fc818
fs: set path when mkdir recursive called on file
bcoe Feb 2, 2020
5982726
net: track state of setNoDelay() and prevent unnecessary system calls
rustyconover Jan 28, 2020
425662e
src: remove unused `Worker::child_port_` member
addaleax Feb 1, 2020
e7fea14
perf_hooks: add property flags to GCPerformanceEntry
fanatid Sep 13, 2019
d2a12d3
test: refactor test-readline-interface.js
BridgeAR Jan 20, 2020
435b9c9
test: abstract common assertions in readline-interface test
BridgeAR Jan 20, 2020
1dbe765
doc: add AsyncResource + Worker pool example
addaleax Feb 1, 2020
6d0b226
stream: fix finished w/ 'close' before 'finish'
ronag Jan 27, 2020
f0ffa4c
src: fix inspecting `MessagePort` from `init` async hook
addaleax Feb 1, 2020
b50a6cc
doc: add example to fs.promises.readdir
conoro Jan 28, 2020
e27f249
doc: ask more questions in the bug report template
joyeecheung Feb 2, 2020
832255d
meta: fix collaborator list errors in README.md
jasnell Feb 6, 2020
23fefba
test: fix flaky test-http2-stream-destroy-event-order
addaleax Feb 1, 2020
6874dee
doc,assert: rename "mode" to "assertion mode"
Trott Feb 4, 2020
ae2141e
n-api: free instance data as reference
Feb 4, 2020
328b8a6
tools: unify make-v8.sh for ppc64le and s390x
richardlau Feb 3, 2020
13c256d
test: add test-dns-promises-lookupService
Trott Feb 4, 2020
2991e7c
doc: correct getting an ArrayBuffer's length
tsabolov Feb 4, 2020
148dfde
readline: make tab size configurable
BridgeAR Jan 12, 2020
b61b85c
doc: add note in BUILDING.md about running `make distclean`
swagatata Jan 28, 2020
2e6c737
doc: remove .github/ISSUE_TEMPLATE.md in favor of the template folder
joyeecheung Feb 6, 2020
3e5803f
worker: improve MessagePort performance
addaleax Feb 1, 2020
4b0085c
doc: update TSC name in "Release Process"
tniessen Feb 5, 2020
af612bc
src: various minor improvements to node_url
jasnell Feb 5, 2020
77ec381
doc: clarify Worker exit/message event ordering
addaleax Feb 5, 2020
8964077
src: fix OOB reads in process.title getter
bnoordhuis Feb 4, 2020
348c787
src: remove fixed-size GetHumanReadableProcessName
bnoordhuis Feb 4, 2020
6139d4e
test: fix flaky test-inspector-connect-main-thread
addaleax Feb 4, 2020
3bcc2da
test: fix test-benchmark-http
Trott Feb 7, 2020
1592c47
worker: reset `Isolate` stack limit after entering `Locker`
addaleax Jan 31, 2020
0e44902
src: remove dead code in InternalMakeCallback
Flarna Feb 3, 2020
1e2327d
doc: simplify async_hooks overview
Trott Feb 6, 2020
60a6977
build: add configure option to debug only Node.js part of the binary
addaleax Feb 5, 2020
1d34ab5
src: modernized unique_ptr construction
Feb 5, 2020
22cf3e3
doc: consolidate introductory text
Trott Feb 6, 2020
161db60
benchmark: check for and fix multiple end()
mscdex Feb 3, 2020
519134d
buffer: improve from() performance
mscdex Feb 2, 2020
9f2c742
benchmark: refactor helper into a class
BridgeAR Jan 16, 2020
ca343ca
benchmark: add `test` and `all` options and improve errors
BridgeAR Jan 16, 2020
4878c7a
test: refactor all benchmark tests to use the new test option
BridgeAR Jan 16, 2020
1484f5a
benchmark: remove special test entries
BridgeAR Jan 20, 2020
89dcf73
test: improve logged errors
BridgeAR Jan 20, 2020
2db7593
assert: align character indicators properly
BridgeAR Jan 20, 2020
58f17c0
test: stricter assert color test
BridgeAR Jan 20, 2020
be55f3e
tty: do not end in an infinite warning recursion
BridgeAR Jan 20, 2020
98f3028
readline: remove intermediate variable
cjihrig Feb 7, 2020
c34872e
test,dns: add coverage for dns exception
Trott Feb 7, 2020
b0e37b7
test: fix flaky test-trace-sigint-on-idle
addaleax Feb 5, 2020
788ea36
doc,net: reword Unix domain path paragraph in net.md
Trott Feb 7, 2020
e3e40a1
doc,util: revise util.md introductory paragraph
Trott Feb 7, 2020
2837788
src: fix compile warnings in node_url.cc
addaleax Feb 7, 2020
6ad8ca5
src: do not unnecessarily re-assign uv handle data
addaleax Feb 8, 2020
2224211
test: improve assertion message in test-dns-any
Trott Feb 8, 2020
2c0f302
test: add debugging output to test-net-listen-after-destroy-stdin
Trott Feb 8, 2020
30f55ce
Revert "benchmark: remove special test entries"
addaleax Feb 10, 2020
5b3c4b3
Revert "test: refactor all benchmark tests to use the new test option"
addaleax Feb 10, 2020
8974fa7
Revert "benchmark: add `test` and `all` options and improve errors"
addaleax Feb 10, 2020
819fb76
Revert "benchmark: refactor helper into a class"
addaleax Feb 10, 2020
d36ba2b
test: fix flaky test-fs-stat-bigint
duncanhealy Nov 12, 2019
fa9b592
test: remove flaky designation for test-fs-stat-bigint
Trott Feb 9, 2020
f6d78f9
doc: improve strict assertion mode color text
Trott Feb 9, 2020
ba9fae0
doc: revise deepEqual() legacy assertion mode text
Trott Feb 9, 2020
6be5129
async_hooks: add executionAsyncResource
mcollina May 4, 2018
9f9edc2
util: throw if unreachable code is reached
Trott Feb 9, 2020
55a25b3
doc: reword section title in addons.md
Trott Feb 10, 2020
d023819
doc: reword possessive form of Node.js in repl.md
Trott Feb 10, 2020
eea58cd
doc: reword possessive form of Node.js in modules.md
Trott Feb 10, 2020
fda97fa
doc: reword possessive form of Node.js in zlib.md
Trott Feb 10, 2020
95d509e
tools: update Markdown linter to be cross-platform
DerekNonGeneric Jan 20, 2020
54caf76
src: allow to reuse env options handling
lundibundi Feb 9, 2020
cd99dc7
worker: properly handle env and NODE_OPTIONS in workers
lundibundi Feb 9, 2020
e23023d
src: add ExclusiveAccess class
bnoordhuis Feb 13, 2020
1dec9d1
src: wrap HostPort in ExclusiveAccess
bnoordhuis Feb 13, 2020
7b9d6d0
util: add coverage for util.inspect.colors alias setter
Trott Feb 11, 2020
a0c1ced
util: throw if unreachable TypedArray checking code is reached
Trott Feb 11, 2020
cd520dd
meta: move calvinmetcalf to emeritus
Trott Feb 11, 2020
f5ae510
meta: move vkurchatkin to emeritus
Trott Feb 11, 2020
15c8d9e
meta: move princejwesley to emeritus
Trott Feb 11, 2020
94a0ec1
doc: update foundation name in onboarding
tniessen Feb 10, 2020
5ae40cd
doc: expand C++ README with information about exception handling
addaleax Feb 10, 2020
b56a21f
doc: add directions to mark a release line as lts
Feb 10, 2020
1dae7dc
test: improve test-fs-stat-bigint
Trott Feb 11, 2020
6dbe6bd
test: fix flaky parallel/test-repl-history-navigation test
BridgeAR Feb 9, 2020
2c83946
doc: fix default server timeout description for https
puzpuzpuz Feb 8, 2020
2ff812c
doc: update contact email for @ryzokuken
ryzokuken Feb 7, 2020
b35f83e
doc: fix typo on fs docs
juanarbol Feb 3, 2020
822f2ac
worker: add support for .cjs extension
aduh95 Feb 6, 2020
c4613c6
doc: add prerequisites information for Arch
ryzokuken Feb 7, 2020
e37f510
benchmark: swap var for let in benchmarks
RamirezAlex Jul 31, 2019
2de085f
benchmark: use let instead of var
dnlup Jan 31, 2020
825d089
crypto: fix performance regression
ronag Feb 11, 2020
2cd8461
doc: add glossary.md
gengjiawen May 1, 2019
0654e67
test: mark test-fs-stat-bigint flaky on FreeBSD
Trott Feb 11, 2020
a840e9d
async_hooks: ensure event after been emitted on runInAsyncScope
legendecas Feb 14, 2020
a095ef0
src: keep main-thread Isolate attached to platform during Dispose
addaleax Feb 14, 2020
7c2d33f
src: use hex not decimal in IsArrayIndex
codebytere Feb 12, 2020
1f0f58c
2020-02-18, Version 13.9.0 (Current)
codebytere Feb 17, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
23 changes: 0 additions & 23 deletions .github/ISSUE_TEMPLATE.md

This file was deleted.

41 changes: 34 additions & 7 deletions .github/ISSUE_TEMPLATE/1-bug-report.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,47 @@ about: Create a report to help us improve
---

<!--
Thank you for reporting a possible bug in Node.js.
Thank you for reporting an issue.

Please fill in as much of the template below as you can.
This issue tracker is for bugs and issues found within Node.js core.
If you require more general support please file an issue on our help
repo. https://github.com/nodejs/help


Please fill in as much of the template below as you're able.

Version: output of `node -v`
Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
Subsystem: if known, please specify the affected core module name

If possible, please provide code that demonstrates the problem, keeping it as
simple and free of external dependencies as you can.
Subsystem: if known, please specify affected core module name
-->

* **Version**:
* **Platform**:
* **Subsystem**:

<!-- Please provide more details below this comment. -->
### What steps will reproduce the bug?

<!--
Enter details about your bug, preferably a simple code snippet that can be
run using `node` directly without installing third-party dependencies.
-->

### How often does it reproduce? Is there a required condition?

### What is the expected behavior?

<!--
If possible please provide textual output instead of screenshots.
-->

### What do you see instead?

<!--
If possible please provide textual output instead of screenshots.
-->

### Additional information

<!--
Tell us anything else you think we should know.
-->
22 changes: 10 additions & 12 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,20 @@ name: CI
on: [push, pull_request]

jobs:
build-linux:
build-docs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 13
uses: actions/setup-node@v1
- name: Build
run: NODE=$(which node) make doc-only
- uses: actions/upload-artifact@v1
with:
node-version: 13.x
name: docs
path: out/doc
build-linux:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Environment Information
run: npx envinfo
- name: Build
Expand All @@ -19,10 +25,6 @@ jobs:
runs-on: windows-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 13
uses: actions/setup-node@v1
with:
node-version: 13.x
- name: Environment Information
run: npx envinfo
- name: Install deps
Expand All @@ -33,10 +35,6 @@ jobs:
runs-on: macos-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 13
uses: actions/setup-node@v1
with:
node-version: 13.x
- name: Environment Information
run: npx envinfo
- name: Build
Expand Down
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@
/config_fips.gypi

# === Rules for MSVS artifacts ===
/Debug
/Release
Debug/
Release/
*.sln
*.suo
*.vcxproj*
Expand Down
17 changes: 15 additions & 2 deletions BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,12 @@ file a new issue.
* [Running Coverage](#running-coverage)
* [Building the documentation](#building-the-documentation)
* [Building a debug build](#building-a-debug-build)
* [Troubleshooting Unix and macOS builds](#troubleshooting-unix-and-macos-builds)
* [Windows](#windows)
* [Prerequisites](#prerequisites)
* [Option 1: Manual install](#option-1-manual-install)
* [Option 2: Automated install with Boxstarter](#option-2-automated-install-with-boxstarter)
* [Building Node.js](#building-nodejs-1)
* [Building Node.js](#building-nodejs-2)
* [Android/Android-based devices (e.g. Firefox OS)](#androidandroid-based-devices-eg-firefox-os)
* [`Intl` (ECMA-402) support](#intl-ecma-402-support)
* [Build with full ICU support (all locales supported by ICU)](#build-with-full-icu-support-all-locales-supported-by-icu)
Expand All @@ -44,7 +45,7 @@ file a new issue.
* [Building without Intl support](#building-without-intl-support)
* [Unix/macOS](#unixmacos-2)
* [Windows](#windows-3)
* [Use existing installed ICU (Unix/macOS only)](#use-existing-installed-icu-unixmacOS-only)
* [Use existing installed ICU (Unix/macOS only)](#use-existing-installed-icu-unixmacos-only)
* [Build with a specific ICU](#build-with-a-specific-icu)
* [Unix/macOS](#unixmacos-3)
* [Windows](#windows-4)
Expand Down Expand Up @@ -243,6 +244,7 @@ Installation via Linux package manager can be achieved with:
* Fedora: `sudo dnf install python gcc-c++ make`
* CentOS and RHEL: `sudo yum install python gcc-c++ make`
* OpenSUSE: `sudo zypper install python gcc-c++ make`
* Arch Linux, Manjaro: `sudo pacman -S python gcc make`

FreeBSD and OpenBSD users may also need to install `libexecinfo`.

Expand Down Expand Up @@ -488,6 +490,17 @@ $ gdb /opt/node-debug/node core.node.8.1535359906
$ backtrace
```

#### Troubleshooting Unix and macOS builds

Stale builds can sometimes result in `file not found` errors while building.
This and some other problems can be resolved with `make distclean`. The
`distclean` recipe aggressively removes build artifacts. You will need to
build again (`make -j4`). Since all build artifacts have been removed, this
rebuild may take a lot more time than previous builds. Additionally,
`distclean` removes the file that stores the results of `./configure`. If you
ran `./configure` with non-default options (such as `--debug`), you will need
to run it again before invoking `make -j4`.

### Windows

#### Prerequisites
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ release.
</tr>
<tr>
<td valign="top">
<b><a href="doc/changelogs/CHANGELOG_V13.md#13.8.0">13.8.0</a></b><br/>
<b><a href="doc/changelogs/CHANGELOG_V13.md#13.9.0">13.9.0</a></b><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.8.0">13.8.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.7.0">13.7.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.6.0">13.6.0</a><br/>
<a href="doc/changelogs/CHANGELOG_V13.md#13.5.0">13.5.0</a><br/>
Expand Down
34 changes: 27 additions & 7 deletions COLLABORATOR_GUIDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
* [Waiting for Approvals](#waiting-for-approvals)
* [Testing and CI](#testing-and-ci)
* [Useful CI Jobs](#useful-ci-jobs)
* [Starting a CI Job](#starting-a-ci-job)
* [Internal vs. Public API](#internal-vs-public-api)
* [Breaking Changes](#breaking-changes)
* [Breaking Changes and Deprecations](#breaking-changes-and-deprecations)
Expand Down Expand Up @@ -191,12 +192,6 @@ everything else. Start a fresh CI if more than seven days have elapsed since
the original failing CI as the compiled binaries for the Windows and ARM
platforms are only kept for seven days.

Some of the CI Jobs may require `GIT_REMOTE_REF` which is the remote portion
of Git refspec. To specify the branch this way `refs/heads/BRANCH` is used
(i.e for `master` -> `refs/heads/master`).
For pull requests it will look like `refs/pull/PR_NUMBER/head`
(i.e. for PR#42 -> `refs/pull/42/head`).

#### Useful CI Jobs

* [`node-test-pull-request`](https://ci.nodejs.org/job/node-test-pull-request/)
Expand All @@ -216,12 +211,37 @@ that the tests are reliable.
runs the standard V8 tests. Run it when updating V8 in Node.js or floating new
patches on V8.

* [`node-test-commit-custom-suites`](https://ci.nodejs.org/job/node-test-commit-custom-suites/)
* [`node-test-commit-custom-suites-freestyle`](https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/)
enables customization of test suites and parameters. It can execute test suites
not used in other CI test runs (such as tests in the `internet` or `pummel`
directories). It can also make sure tests pass when provided with a flag not
used in other CI test runs (such as `--worker`).

#### Starting a CI Job

From the CI Job page, click "Build with Parameters" on the left side.

You generally need to enter only one or both of the following options
in the form:

* `GIT_REMOTE_REF`: Change to the remote portion of git refspec.
To specify the branch this way, `refs/heads/BRANCH` is used
(e.g. for `master` -> `refs/heads/master`).
For pull requests, it will look like `refs/pull/PR_NUMBER/head`
(e.g. for PR#42 -> `refs/pull/42/head`).
* `REBASE_ONTO`: Change that to `origin/master` so the pull request gets rebased
onto master. This can especially be important for pull requests that have been
open a while.

Look at the list of jobs on the left hand side under "Build History" and copy
the link to the one you started (which will be the one on top, but click
through to make sure it says something like "Started 5 seconds ago"
(top right) and "Started by user ...".

Copy/paste the URL for the job into a comment in the pull request.
[`node-test-pull-request`](https://ci.nodejs.org/job/node-test-pull-request/)
is an exception where the GitHub bot will automatically post for you.

### Internal vs. Public API

All functionality in the official Node.js documentation is part of the public
Expand Down
22 changes: 12 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -261,8 +261,6 @@ For information about the governance of the Node.js project, see
**Ruben Bridgewater** &lt;ruben@bridgewater.de&gt; (he/him)
* [bzoz](https://github.com/bzoz) -
**Bartosz Sosnowski** &lt;bartosz@janeasystems.com&gt;
* [calvinmetcalf](https://github.com/calvinmetcalf) -
**Calvin Metcalf** &lt;calvin.metcalf@gmail.com&gt;
* [cclauss](https://github.com/cclauss) -
**Christian Clauss** &lt;cclauss@me.com&gt; (he/him)
* [ChALkeR](https://github.com/ChALkeR) -
Expand Down Expand Up @@ -353,7 +351,7 @@ For information about the governance of the Node.js project, see
**Denys Otrishko** &lt;shishugi@gmail.com&gt; (he/him)
* [maclover7](https://github.com/maclover7) -
**Jon Moss** &lt;me@jonathanmoss.me&gt; (he/him)
* [mafintosh](https://github.com/mafintosh)
* [mafintosh](https://github.com/mafintosh) -
**Mathias Buus** &lt;mathiasbuus@gmail.com&gt; (he/him)
* [mcollina](https://github.com/mcollina) -
**Matteo Collina** &lt;matteo.collina@gmail.com&gt; (he/him)
Expand All @@ -375,8 +373,6 @@ For information about the governance of the Node.js project, see
**Ali Ijaz Sheikh** &lt;ofrobots@google.com&gt; (he/him)
* [oyyd](https://github.com/oyyd) -
**Ouyang Yadong** &lt;oyydoibh@gmail.com&gt; (he/him)
* [princejwesley](https://github.com/princejwesley) -
**Prince John Wesley** &lt;princejohnwesley@gmail.com&gt;
* [psmarshall](https://github.com/psmarshall) -
**Peter Marshall** &lt;petermarshall@chromium.org&gt; (he/him)
* [Qard](https://github.com/Qard) -
Expand All @@ -385,14 +381,16 @@ For information about the governance of the Node.js project, see
**Refael Ackermann (רפאל פלחי)** &lt;refack@gmail.com&gt; (he/him/הוא/אתה)
* [richardlau](https://github.com/richardlau) -
**Richard Lau** &lt;riclau@uk.ibm.com&gt;
* [ronag](https://github.com/ronag) -
**Robert Nagy** &lt;ronagy@icloud.com&gt;
* [ronkorving](https://github.com/ronkorving) -
**Ron Korving** &lt;ron@ronkorving.nl&gt;
* [rubys](https://github.com/rubys) -
**Sam Ruby** &lt;rubys@intertwingly.net&gt;
* [rvagg](https://github.com/rvagg) -
**Rod Vagg** &lt;rod@vagg.org&gt;
* [ryzokuken](https://github.com/ryzokuken) -
**Ujjwal Sharma** &lt;usharma1998@gmail.com&gt; (he/him)
**Ujjwal Sharma** &lt;ryzokuken@disroot.org&gt; (he/him)
* [saghul](https://github.com/saghul) -
**Saúl Ibarra Corretgé** &lt;saghul@gmail.com&gt;
* [sam-github](https://github.com/sam-github) -
Expand Down Expand Up @@ -431,8 +429,6 @@ For information about the governance of the Node.js project, see
**Rich Trott** &lt;rtrott@gmail.com&gt; (he/him)
* [vdeturckheim](https://github.com/vdeturckheim) -
**Vladimir de Turckheim** &lt;vlad2t@hotmail.com&gt; (he/him)
* [vkurchatkin](https://github.com/vkurchatkin) -
**Vladimir Kurchatkin** &lt;vladimir.kurchatkin@gmail.com&gt;
* [watilde](https://github.com/watilde) -
**Daijiro Wachi** &lt;daijiro.wachi@gmail.com&gt; (he/him)
* [watson](https://github.com/watson) -
Expand All @@ -456,12 +452,14 @@ For information about the governance of the Node.js project, see
**Anna M. Kedzierska** &lt;anna.m.kedzierska@gmail.com&gt;
* [brendanashworth](https://github.com/brendanashworth) -
**Brendan Ashworth** &lt;brendan.ashworth@me.com&gt;
* [estliberitas](https://github.com/estliberitas) -
**Alexander Makarenko** &lt;estliberitas@gmail.com&gt;
* [calvinmetcalf](https://github.com/calvinmetcalf) -
**Calvin Metcalf** &lt;calvin.metcalf@gmail.com&gt;
* [chrisdickinson](https://github.com/chrisdickinson) -
**Chris Dickinson** &lt;christopher.s.dickinson@gmail.com&gt;
* [DavidCai1993](https://github.com/DavidCai1993) -
**David Cai** &lt;davidcai1993@yahoo.com&gt; (he/him)
* [estliberitas](https://github.com/estliberitas) -
**Alexander Makarenko** &lt;estliberitas@gmail.com&gt;
* [firedfox](https://github.com/firedfox) -
**Daniel Wang** &lt;wangyang0123@gmail.com&gt;
* [imran-iq](https://github.com/imran-iq) -
Expand Down Expand Up @@ -504,6 +502,8 @@ For information about the governance of the Node.js project, see
**Bert Belder** &lt;bertbelder@gmail.com&gt;
* [pmq20](https://github.com/pmq20) -
**Minqi Pan** &lt;pmq2001@gmail.com&gt;
* [princejwesley](https://github.com/princejwesley) -
**Prince John Wesley** &lt;princejohnwesley@gmail.com&gt;
* [rlidwka](https://github.com/rlidwka) -
**Alex Kocharin** &lt;alex@kocharin.ru&gt;
* [rmg](https://github.com/rmg) -
Expand All @@ -522,6 +522,8 @@ For information about the governance of the Node.js project, see
**Thorsten Lorenz** &lt;thlorenz@gmx.de&gt;
* [tunniclm](https://github.com/tunniclm) -
**Mike Tunnicliffe** &lt;m.j.tunnicliffe@gmail.com&gt;
* [vkurchatkin](https://github.com/vkurchatkin) -
**Vladimir Kurchatkin** &lt;vladimir.kurchatkin@gmail.com&gt;
* [vsemozhetbyt](https://github.com/vsemozhetbyt) -
**Vse Mozhet Byt** &lt;vsemozhetbyt@gmail.com&gt; (he/him)
* [whitlockjc](https://github.com/whitlockjc) -
Expand Down
Loading