Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove common.PORT from test-net-write-callbacks.js #31839

Merged
merged 1 commit into from
Feb 20, 2020
Merged

test: remove common.PORT from test-net-write-callbacks.js #31839

merged 1 commit into from
Feb 20, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 18, 2020

Switch test-net-write-callbacks.js from common.PORT to a port assigned
by the operating system.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 18, 2020
addaleax
addaleax approved these changes Feb 18, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m also good with deleting the test entirely or moving it to parallel with a lower N.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29194/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 18, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29205/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29206/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29209/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29223/

@Trott
Copy link
Member Author

Trott commented Feb 19, 2020

Pummel-specific CI, since the pummel tests are skipped in our routine pull-request CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12311/

@Trott
test: remove common.PORT from test-net-write-callbacks.js
1c4e984 
Switch test-net-write-callbacks.js from common.PORT to a port assigned
by the operating system.

PR-URL: nodejs#31839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott Trott force-pushed the test-net-write-callbacks.js branch from 1958218 to 1c4e984 Compare February 20, 2020 02:58
@Trott Trott merged commit 1c4e984 into nodejs:master Feb 20, 2020
@Trott
Copy link
Member Author

Trott commented Feb 20, 2020

Landed in 1c4e984

@Trott Trott deleted the test-net-write-callbacks.js branch February 20, 2020 02:59
codebytere pushed a commit that referenced this pull request Feb 27, 2020
@Trott @codebytere
test: remove common.PORT from test-net-write-callbacks.js
1933efa 
Switch test-net-write-callbacks.js from common.PORT to a port assigned
by the operating system.

PR-URL: #31839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebytere codebytere mentioned this pull request Feb 29, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott @codebytere
test: remove common.PORT from test-net-write-callbacks.js
905801b 
Switch test-net-write-callbacks.js from common.PORT to a port assigned
by the operating system.

PR-URL: #31839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
test: remove common.PORT from test-net-write-callbacks.js
3f93b5e 
Switch test-net-write-callbacks.js from common.PORT to a port assigned
by the operating system.

PR-URL: #31839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott @codebytere
test: remove common.PORT from test-net-write-callbacks.js
c386f75 
Switch test-net-write-callbacks.js from common.PORT to a port assigned
by the operating system.

PR-URL: #31839
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

@codebytere codebytere codebytere approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @nodejs-github-bot @jasnell @addaleax @lpinca @codebytere @cjihrig @richardlau @ZYSzys