Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: fix not emit removeListener #31846

Closed
wants to merge 1 commit into from
Closed

events: fix not emit removeListener #31846

wants to merge 1 commit into from

Commits on Feb 18, 2020

  1. events: fix not emit removeListener

    Fix not emit removeListener  when type of eventName is 'symbol'
    
    ```js
    const EventEmitter = require('events');
    const myEmitter = new EventEmitter();
    const sym = Symbol('symbol');
    const fn = () => { };
    myEmitter.on(sym, fn);
    
    myEmitter.on('removeListener', (...args) => {
      console.log('removeListener');
      console.log(args, args[0] === sym, args[1] === fn);
    });
    
    myEmitter.removeAllListeners()
    ```
    fuxingZhang committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    671588c View commit details
    Browse the repository at this point in the history