Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix ieee-p1363 for createVerify #31876

Closed
wants to merge 1 commit into from
Closed

crypto: fix ieee-p1363 for createVerify #31876

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

Even though createVerify was correctly converting ieee-p1363 signatures to DER, it then passed a pointer to the ieee-p1363 signature to OpenSSL, instead of a pointer to the result of the conversion. My mistake, sorry.

Fixes: #31866

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@tniessen tniessen added the crypto Issues and PRs related to the crypto subsystem. label Feb 20, 2020
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 20, 2020
@tniessen tniessen mentioned this pull request Feb 20, 2020
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29286/

tniessen added a commit that referenced this pull request Feb 23, 2020
@tniessen
crypto: fix ieee-p1363 for createVerify
0e63a07 
Fixes: #31866

PR-URL: #31876
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@tniessen
Copy link
Member Author

Landed in 0e63a07, thanks for reviewing.

@tniessen tniessen closed this Feb 23, 2020
@tniessen tniessen deleted the crypto-fix-31886 branch February 23, 2020 02:11
codebytere pushed a commit that referenced this pull request Feb 27, 2020
@tniessen @codebytere
crypto: fix ieee-p1363 for createVerify
d0e94fc 
Fixes: #31866

PR-URL: #31876
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Feb 29, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@tniessen @codebytere
crypto: fix ieee-p1363 for createVerify
3796501 
Fixes: #31866

PR-URL: #31876
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@tniessen @codebytere
crypto: fix ieee-p1363 for createVerify
0042e3e 
Fixes: #31866

PR-URL: #31876
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@tniessen @codebytere
crypto: fix ieee-p1363 for createVerify
c6bbae4 
Fixes: #31866

PR-URL: #31876
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verification with dsaEncoding ieee-p1363 fails.
5 participants
@tniessen @nodejs-github-bot @bnoordhuis @jasnell @cjihrig