Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace instances of common.PORT in pummel tests with port "0" #31897

Merged
merged 1 commit into from
Feb 23, 2020
Merged

test: replace instances of common.PORT in pummel tests with port "0" #31897

merged 1 commit into from
Feb 23, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 21, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 21, 2020
@Trott
Copy link
Member Author

Trott commented Feb 21, 2020 •
edited
Loading

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12332/ ✅

mhdawson
mhdawson approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as good in CI, LGTM

@Trott
Copy link
Member Author

Trott commented Feb 21, 2020

As long as good in CI, LGTM

Pummel tests don't run in our regular CI, but it's all green in the special CI above.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 21, 2020
@Trott
test: remove common.PORT from assorted pummel tests
97c8abe 
Use port "0" for an OS-provided open port instead of common.PORT.

PR-URL: nodejs#31897
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@Trott Trott merged commit 97c8abe into nodejs:master Feb 23, 2020
@Trott
Copy link
Member Author

Trott commented Feb 23, 2020

Landed in 97c8abe

@Trott Trott deleted the port-0 branch February 23, 2020 10:47
codebytere pushed a commit that referenced this pull request Feb 27, 2020
@Trott @codebytere
test: remove common.PORT from assorted pummel tests
4fe9e04 
Use port "0" for an OS-provided open port instead of common.PORT.

PR-URL: #31897
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@codebytere codebytere mentioned this pull request Feb 29, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@Trott @codebytere
test: remove common.PORT from assorted pummel tests
950c3c3 
Use port "0" for an OS-provided open port instead of common.PORT.

PR-URL: #31897
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@Trott @codebytere
test: remove common.PORT from assorted pummel tests
e5ebbd6 
Use port "0" for an OS-provided open port instead of common.PORT.

PR-URL: #31897
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@Trott @codebytere
test: remove common.PORT from assorted pummel tests
3deee05 
Use port "0" for an OS-provided open port instead of common.PORT.

PR-URL: #31897
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@lundibundi lundibundi lundibundi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @lundibundi @mhdawson @nodejs-github-bot