Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing original env variable issue on multiple test cases. #3191

Closed
wants to merge 1 commit into from

Conversation

john-yan
Copy link

@john-yan john-yan commented Oct 5, 2015

When the parent spawn the child processes, the environment variables passing into the child processes are missing the original env variables passing into the parent. Some missing variables like LD_LIBRARY_PATH cause the child processes unable to run.

PR-URL: #3183

@rvagg
Copy link
Member

rvagg commented Oct 5, 2015

lgtm

I imagine the proper way to do this is with Object.assign() but since it's tests I'm not sure it matters, anyone else have an opinion on that?

@rvagg
Copy link
Member

rvagg commented Oct 5, 2015

I'm going to close this one in favour of #3190 which is against master, we'll do the cherry-picking later @john-yan but thanks anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants