-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standardizes references to 'userland' issue #3189 #3192
Conversation
@@ -2975,7 +2975,7 @@ https://iojs.org/api/tls.html | |||
- Added async session storage events. | |||
- Added async SNI callback. | |||
- Added multi-key server support (for example, ECDSA+RSA server). | |||
- Added optional callback to `checkServerIdentity` for manual certificate validation in user-land. | |||
- Added optional callback to `checkServerIdentity` for manual certificate validation in userland. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it cool to change the CHANGELOG after the fact like this for what amounts to (at worst) a typo? I personally think it's totally fine but uh...anyone have a problem with it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unnecessary but harmless, in my opinion. It's in accord with the idea of standardizing the references - the more people see "userland" instead of "user-land" the more it catches on.
Hmmm...guess there's not that many instances to change now that I see that a handful of the files are in |
Yeah, changing dependency files doesn't make sense. I've undone those modifications. |
LGTM. |
@MJefferson Thanks for the contribution! If you can squash the two commits into one commit, that would be great. (And if not, no worries, I or someone else will do it when the change is landed.) If you squash the commit, it would be great if you could also change the commit message to match the guideline in the CONTIRBUTING doc. (And again, if not, I or someone else will just do it for when the change is landed.) Since it may not be clear in this case, I would use |
33904d0
to
70a00e1
Compare
Done. My pleasure @Trott. : ) |
Landed in f5a3f44. Thanks for the patch! |
Decided to standardize from "user-land" to "userland" as the latter appears more frequently in the docs.