Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardizes references to 'userland' issue #3189 #3192

Closed
wants to merge 1 commit into from

Conversation

MJefferson
Copy link
Contributor

Decided to standardize from "user-land" to "userland" as the latter appears more frequently in the docs.

@@ -2975,7 +2975,7 @@ https://iojs.org/api/tls.html
- Added async session storage events.
- Added async SNI callback.
- Added multi-key server support (for example, ECDSA+RSA server).
- Added optional callback to `checkServerIdentity` for manual certificate validation in user-land.
- Added optional callback to `checkServerIdentity` for manual certificate validation in userland.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it cool to change the CHANGELOG after the fact like this for what amounts to (at worst) a typo? I personally think it's totally fine but uh...anyone have a problem with it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unnecessary but harmless, in my opinion. It's in accord with the idea of standardizing the references - the more people see "userland" instead of "user-land" the more it catches on.

@Trott
Copy link
Member

Trott commented Oct 5, 2015

Hmmm...guess there's not that many instances to change now that I see that a handful of the files are in deps. If you can undo the changes to the files in deps, I think it's good to go.

@Trott Trott added the doc Issues and PRs related to the documentations. label Oct 5, 2015
@MJefferson
Copy link
Contributor Author

Yeah, changing dependency files doesn't make sense. I've undone those modifications.

@Trott
Copy link
Member

Trott commented Oct 6, 2015

LGTM.

@Trott
Copy link
Member

Trott commented Oct 6, 2015

@MJefferson Thanks for the contribution!

If you can squash the two commits into one commit, that would be great. (And if not, no worries, I or someone else will do it when the change is landed.)

If you squash the commit, it would be great if you could also change the commit message to match the guideline in the CONTIRBUTING doc. (And again, if not, I or someone else will just do it for when the change is landed.) Since it may not be clear in this case, I would use doc as the subsystem. So the first line of the commit message might look something like this: doc: standardize references to userland

@MJefferson
Copy link
Contributor Author

Done. My pleasure @Trott. : )

@Trott
Copy link
Member

Trott commented Oct 7, 2015

Landed in f5a3f44. Thanks for the patch!

@Trott Trott closed this Oct 7, 2015
Trott pushed a commit that referenced this pull request Oct 7, 2015
Change occurrences of "user-land" to "userland".

PR-URL: #3192
Fixes: #3189
Reviewed-By: Rich Trott <rtrott@gmail.com>
@jasnell jasnell mentioned this pull request Oct 8, 2015
29 tasks
jasnell pushed a commit that referenced this pull request Oct 8, 2015
Change occurrences of "user-land" to "userland".

PR-URL: #3192
Fixes: #3189
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants